Python: prefilter directly controlled SSA uses - #156
Draft
yoff wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03758eab-d713-4ffb-87bd-64ceb863dd3b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(guard, use, branch)control relation before matching shared-SSA definitions.AdjacentUses::useOfDeflookup.Stacked directly on draft #154 at
d75f96aca016100826c64a5e8185ea63fdae8edf.Evidence
FreeCAD
py/modification-of-default-value:directGuardedUse: exactly 4,993 rows before and after.61120da95b48e6a9f3afbbcf82d54fd2775d695a501ae5bc357aefe46410583e.613ba8a9cac7fae61d2a911178de7eca60e70575dbf4db9dfb526bfb0a4c8967before and after.Independent controls:
py/clear-text-logging-sensitive-data: byte-identical QL hash/DIL/RA and therefore unaffected; the local control retains 130 results and the 21.7 MB BQRS production flip.The helper adds two small pipeline starts per evaluation; these replace the dominant expansion. An inline-only formulation was rejected because it compiled to the original RA and retained the 1.581B-row join.
Validation
codeql query format --check-only python/ql/src/semmle/python/functions/ModificationOfParameterWithDefaultCustomizations.qllcodeql test run -j1 python/ql/test/query-tests/Functions/ModificationOfParameterWithDefault(3 tests passed, includingBarrierGuardSpecialization.ql)python/ql/src/Security/CWE-078/CommandInjection.qlcontrol (exact output)The code commit retains validated stable patch-id
3307faf03796b54c45c6ae0975a083a97811e775.