Skip to content

Correct AsyncHttpClient::sendRequest method name #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asika32764 merged 3 commits into from
Nov 8, 2026
Merged

Correct AsyncHttpClient::sendRequest method name #1387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ce1158
Initial plan
Copilot Nov 7, 2026
548d404
Rename AsyncHttpClient request method
Copilot Nov 7, 2026
8763dad
Keep deprecated AsyncHttpClient method alias
Copilot Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/http/src/AsyncHttpClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public function reset(): static
* @return Promise
* @throws RangeException
*/
public function senRequest(RequestInterface $request): ResponseInterface
public function sendRequest(RequestInterface $request): ResponseInterface
{
/** @var CurlTransport $transport */
$transport = $this->getTransport();
Expand All @@ -136,6 +136,20 @@ public function senRequest(RequestInterface $request): ResponseInterface
return $promise;
}

/**
* Send a request to remote.
*
* @param RequestInterface $request The PSR request object.
*
* @return Promise
*
* @deprecated Use sendRequest() instead.
*/
public function senRequest(RequestInterface $request): ResponseInterface
{
return $this->sendRequest($request);
}

/**
* resolve
*
Expand Down
26 changes: 18 additions & 8 deletions packages/http/test/AsyncHttpClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,17 @@ public function setTransportRejectsStreamTransport(): void
}

#[Test]
public function senRequestQueuesTaskAndReturnsPromise(): void
public function sendRequestQueuesTaskAndReturnsPromise(): void
{
$promise = $this->instance->sendRequest($this->createRequest('/json?a=1'));

self::assertInstanceOf(PromiseResponse::class, $promise);
self::assertCount(1, $this->instance->getHandles());
self::assertCount(1, $this->instance->getTasks());
}

#[Test]
public function senRequestForwardsToSendRequest(): void
{
$promise = $this->instance->senRequest($this->createRequest('/json?a=1'));

Expand All @@ -105,8 +115,8 @@ public function senRequestQueuesTaskAndReturnsPromise(): void
#[Test]
public function resolveReturnsResponsesForAllQueuedRequests(): void
{
$this->instance->senRequest($this->createRequest('/json?a=1'));
$this->instance->senRequest($this->createRequest('/json?a=2'));
$this->instance->sendRequest($this->createRequest('/json?a=1'));
$this->instance->sendRequest($this->createRequest('/json?a=2'));

$responses = $this->instance->resolve();

Expand All @@ -122,7 +132,7 @@ public function resolveResolvesPromisesWithResponses(): void
{
$received = [];

$promise = $this->instance->senRequest($this->createRequest('/json?a=3'));
$promise = $this->instance->sendRequest($this->createRequest('/json?a=3'));
$promise->then(
function (Response $res) use (&$received) {
$received[] = (string) $res->getBody();
Expand All @@ -139,7 +149,7 @@ function (Response $res) use (&$received) {
#[Test]
public function resolveInvokesCallbackWithResponsesErrorsAndClient(): void
{
$this->instance->senRequest($this->createRequest('/json?a=1'));
$this->instance->sendRequest($this->createRequest('/json?a=1'));

$args = null;

Expand All @@ -159,7 +169,7 @@ public function resolveRejectsPromiseAndCollectsErrorOnConnectionFailure(): void
{
$failure = null;

$promise = $this->instance->senRequest(
$promise = $this->instance->sendRequest(
$this->createUrlRequest('http://127.0.0.1:1/unreachable'),
);
$promise->fail(
Expand Down Expand Up @@ -187,7 +197,7 @@ function (array $responses, array $errs) use (&$errors) {
#[Test]
public function resolveResetsQueueAfterCompletion(): void
{
$this->instance->senRequest($this->createRequest('/json?a=1'));
$this->instance->sendRequest($this->createRequest('/json?a=1'));
$this->instance->resolve();

self::assertSame([], $this->instance->getHandles());
Expand All @@ -197,7 +207,7 @@ public function resolveResetsQueueAfterCompletion(): void
#[Test]
public function resetClearsTasksAndMainHandle(): void
{
$this->instance->senRequest($this->createRequest('/json?a=1'));
$this->instance->sendRequest($this->createRequest('/json?a=1'));
$mh = $this->instance->getMainHandle();

self::assertSame($this->instance, $this->instance->reset());
Expand Down