Skip to content

Correct AsyncHttpClient::sendRequest method name - #1387

Merged
asika32764 merged 3 commits into
masterfrom
copilot/fix-asynchttpclient-sendrequest-typo
Nov 8, 2026
Merged

asika32764 merged 3 commits into
masterfrom
copilot/fix-asynchttpclient-sendrequest-typo

Conversation

Copilot AI commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

AsyncHttpClient exposed its request method as senRequest(), inconsistent with the expected sendRequest() API.

  • API: Rename the method to sendRequest().
  • Tests: Update existing call sites to use the corrected name.
$promise = $client->sendRequest($request);

Co-authored-by: asika32764 <1639206+asika32764@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix typo in AsyncHttpClient::sendRequest method Correct AsyncHttpClient::sendRequest method name Nov 7, 2026
Copilot AI requested a review from asika32764 November 7, 2026 17:46
@asika32764

Copy link
Copy Markdown
Member

@copilot keep the wrong name senRequest still exists and deprecated it, then proxy to correct method

Co-authored-by: asika32764 <1639206+asika32764@users.noreply.github.com>

Copilot AI commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

@copilot keep the wrong name senRequest still exists and deprecated it, then proxy to correct method

Added the deprecated senRequest() compatibility proxy to sendRequest() and a regression test. Committed as 8763dad.

@asika32764
asika32764 marked this pull request as ready for review November 8, 2026 03:59
@asika32764
asika32764 merged commit e3b102d into master Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AsyncHttpClient::senRequest should be sendRequest

2 participants