[core] Keep step results ordered behind waits parked on unread hook payloads (#3406) (backport to stable) by VaguelySerious · Pull Request #3718 · vercel/workflow

VaguelySerious · 2026-08-21T20:22:09Z

Manual backport of #3406 (cherry-pick fbebf710) to stable.

This is the prerequisite for the #3700 backport (#3702), which cannot terminate without it. Opened separately so the two land in order.

Why this is on stable's critical path

#3700's log-order-draws turnstile waits on any lower armed barrier, which is a wider waits-for relation than gatesOn. Its deadlock-freedom argument rests on this PR's change to computeResolvesOnItsOwn: with the unconditional step -> true shortcut in place, a step spinning above an armed wait parked behind an unclaimed hook payload is reported self-resolving, hasParkedCommittedDelivery stays true, the dispenser never retires the payload, and the chain never opens.

Verified empirically: with #3700 cherry-picked onto stable without this commit, its own turnstile termination pin fails with Unconsumed event: step_created. With this commit underneath, the full unit suite is green in both flag modes.

Separately, this is a CORRUPTED_EVENT_LOG fix in its own right (a step result overtaking an earlier wait_completed through an unread hook payload) and belongs on the maintenance line regardless.

Adaptations

private.ts: the cherry-pick's awaitEarlierDeliveries doc block reverted [core] Pin draw order to event-log order: retire delivery barriers through one ordered dispenser #3554's dispenser paragraph back to the pre-[core] Pin draw order to event-log order: retire delivery barriers through one ordered dispenser #3554 per-barrier-FIFO argument, which is stale on stable (Backport #3554: [core] Pin draw order to event-log order: retire delivery barriers through one ordered dispenser #3629 already landed [core] Pin draw order to event-log order: retire delivery barriers through one ordered dispenser #3554). Resolved to main's converged text, so gatesOn, resolvesOnItsOwn, computeResolvesOnItsOwn and awaitEarlierDeliveries are now byte-identical to main.
delivery-barrier-coverage.test.ts: section renumbered 4 -> 3 and "Cases 1-3" kept as "Cases 1-2". stable has no workflow AbortController, so the abort-delivery section the upstream file carries is not portable (the header already recorded that from the Backport #3554: [core] Pin draw order to event-log order: retire delivery barriers through one ordered dispenser #3629 backport).
workbench/fastify/public/index.html (an unrelated deletion in the upstream commit) does not exist on stable and is dropped.

Verification

pnpm vitest run src/ in packages/core: 853 passed, 3 expected fail, 3 skipped, 0 failures.
@workflow/core build (tsc) clean.
Biome reports no new findings on the changed files.

…ayloads (#3406) (cherry picked from commit fbebf71) # Conflicts: # packages/core/src/delivery-barrier-coverage.test.ts # packages/core/src/private.ts

vercel · 2026-08-21T20:22:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
example-nextjs-workflow-turbopack	Ready	Preview, v0	Aug 21, 2026 8:25pm
example-nextjs-workflow-webpack	Ready	Preview, v0	Aug 21, 2026 8:25pm
example-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workbench-astro-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workbench-express-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workbench-fastify-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workbench-hono-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workbench-nestjs-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workbench-nitro-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workbench-nuxt-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workbench-python-workflow	Error	v0	Aug 21, 2026 8:25pm
workbench-sveltekit-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workbench-tanstack-start-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workbench-vite-workflow	Ready	Preview, v0	Aug 21, 2026 8:25pm
workflow-docs	Ready	Preview, v0	Aug 21, 2026 8:25pm
workflow-swc-playground	Ready	Preview, v0	Aug 21, 2026 8:25pm
workflow-tarballs	Ready	Preview, v0	Aug 21, 2026 8:25pm
workflow-web	Ready	Preview, v0	Aug 21, 2026 8:25pm

changeset-bot · 2026-08-21T20:22:17Z

🦋 Changeset detected

Latest commit: dc97a73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@workflow/core	Patch
@workflow/builders	Patch
@workflow/cli	Patch
@workflow/next	Patch
@workflow/nitro	Patch
@workflow/vitest	Patch
@workflow/web-shared	Patch
@workflow/web	Patch
workflow	Patch
@workflow/world-testing	Patch
@workflow/astro	Patch
@workflow/nest	Patch
@workflow/rollup	Patch
@workflow/sveltekit	Patch
@workflow/vite	Patch
@workflow/nuxt	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-08-21T20:22:19Z

🧪 E2E Test Results

❌ Some tests failed

Summary

	Passed	Failed	Skipped	Total
✅ ▲ Vercel Production	1099	0	78	1177
✅ 💻 Local Development	1198	0	86	1284
✅ 📦 Local Production	1198	0	86	1284
✅ 🐘 Local Postgres	1198	0	86	1284
✅ 🪟 Windows	107	0	0	107
❌ 🌍 Community Worlds	83	105	9	197
✅ 📋 Other	606	0	36	642
Total	5489	105	381	5975

❌ Failed Tests

🌍 Community Worlds (105 failed)

redis (20 failed):

hookWorkflow is not resumable via public webhook endpoint | wrun_01M0JZY3SXEQ6CHDVDW2HCSC4M
parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M0JZYCVGYQYF0MMVM9BT1MGG
sleepingWorkflow | wrun_01M0JZZA2YCXM438HQ74SAHSAZ
outputStreamWorkflow negative startIndex (reads from end)
outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
error handling serialization failures step-argument serialization failure is catchable in workflow code
error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M0K07A4YE71AMKES6QF06EJA
hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M0K07PK962CAY66RFN2SFWFB
hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M0K07XQYRJ461ZGJE77FK5J6
hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M0K08AYP898BATRSHW8P3K6W
hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M0K094X6XM05H8N7HRRR32DA
hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M0K09889XDTN367K2RYHKE08
hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M0K09F16CGR0E28K7MHF3N5Z
hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M0K09KH35QEXGR487DBJJS7Q
resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M0K09W9278NVG53M1W56H4FH
pages router sleepingWorkflow via pages router
resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M0K0FE1J8VP6EVDKYS0HXYT0

turso (85 failed):

addTenWorkflow | wrun_01M0JZX1R0YKVVFSMMBS26MJY3
addTenWorkflow | wrun_01M0JZX1R0YKVVFSMMBS26MJY3
deploymentId: 'latest' is a no-op in non-Vercel worlds
wellKnownAgentWorkflow (.well-known/agent) | wrun_01M0JZYR7MGJY86MPSYKM2K5XH
should work with react rendering in step
promiseAllWorkflow | wrun_01M0JZX8PRW8NM1MY2NBHKT611
promiseRaceWorkflow | wrun_01M0JZXC9YT2CAEA9A7N1PHFP1
promiseAnyWorkflow | wrun_01M0JZXEH9W0P4JWJ0RPE08QKN
importedStepOnlyWorkflow | wrun_01M0JZZ3TZK9J97AR0TQA9P0ZA
readableStreamWorkflow | wrun_01M0JZXGPNS6R3T4V0F2W599TR
hookWorkflow | wrun_01M0JZXWWZJ0SKD2ZTSQ2ATSV0
hookWorkflow is not resumable via public webhook endpoint | wrun_01M0JZY3SXEQ6CHDVDW2HCSC4M
webhookWorkflow | wrun_01M0JZY80C76ENWTMJ4GEAMA2X
parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01M0JZYCVGYQYF0MMVM9BT1MGG
sleepingWorkflow | wrun_01M0JZZA2YCXM438HQ74SAHSAZ
parallelSleepWorkflow | wrun_01M0JZZS0V3NPRXY9ZB0X57XQR
sleepWinsRaceWorkflow | wrun_01M0JZZWVX1JH9PK5DG4E7XZSQ
stepWinsRaceWorkflow | wrun_01M0K0009YW9XEDA992QMGPRT9
nullByteWorkflow | wrun_01M0K003SCH0TNVV58JVBJNSYP
workflowAndStepMetadataWorkflow | wrun_01M0K005ZXPHP1VB5X04WX7CP1
outputStreamWorkflow no startIndex (reads all chunks)
outputStreamWorkflow positive startIndex (skips first chunk)
outputStreamWorkflow negative startIndex (reads from end)
outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01M0K02BEDXBW200SV69BPWFRX
writableForwardedFromWorkflowWorkflow | wrun_01M0K02R4YVMTGA2TFA5HTMQHX
writableForwardedFromStepWorkflow | wrun_01M0K02V54SPJDHQB0K9RDGHWZ
fetchWorkflow | wrun_01M0K02YHWSVTE7DDR8WNDFBRZ
promiseRaceStressTestWorkflow | wrun_01M0K031WQ287RP21BV9W2E8D0
error handling error propagation workflow errors nested function calls preserve message and stack trace
error handling error propagation workflow errors cross-file imports preserve message and stack trace
error handling error propagation step errors basic step error preserves message and stack trace
error handling error propagation step errors cross-file step error preserves message and function names in stack
error handling retry behavior regular Error retries until success
error handling retry behavior FatalError fails immediately without retries
error handling retry behavior RetryableError respects custom retryAfter delay
error handling retry behavior maxRetries=0 disables retries
error handling catchability FatalError can be caught and detected with FatalError.is()
error handling serialization failures step-argument serialization failure is catchable in workflow code
error handling serialization failures uncaught step-argument serialization failure fails the run as USER_ERROR without redelivery retries
error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
error handling not registered StepNotRegisteredError fails the step but workflow can catch it
error handling not registered StepNotRegisteredError fails the run when not caught in workflow
hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01M0K06XRT814XDD9FA36JVJ00
concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01M0K07A4YE71AMKES6QF06EJA
hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01M0K07PK962CAY66RFN2SFWFB
'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01M0K07RXVSCGJN5WK2GKF0WET
'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01M0K07V9NK8M4CT80G5E3T22B
hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01M0K07XQYRJ461ZGJE77FK5J6
hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01M0K08AYP898BATRSHW8P3K6W
hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01M0K094X6XM05H8N7HRRR32DA
hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01M0K09889XDTN367K2RYHKE08
hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01M0K09F16CGR0E28K7MHF3N5Z
hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01M0K09KH35QEXGR487DBJJS7Q
resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01M0K09W9278NVG53M1W56H4FH
hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01M0K0A60BNR4ZVE66EQJDFCRR
stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01M0K0APB8QD0TCA6J7GFRAA4A
stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01M0K0B0NW7VGN5DNP0PVDY9KR
closureVariableWorkflow - nested step functions with closure variables | wrun_01M0K0B65NTNEJ1TD70MABXV0R
spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01M0K0B8H7C3D3NFEG8WFSKC9P
health check (queue-based) - workflow and step endpoints respond to health check messages
health check (CLI) - workflow health command reports healthy endpoints
pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01M0K0BR79VPV2994AX1HC38M4
Calculator.calculate - static workflow method using static step methods from another class | wrun_01M0K0BXWKKSK54NVMXWXWSR4Z
AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01M0K0C4GSC8696A0GDFE9D6D5
ChainableService.processWithThis - static step methods using this to reference the class | wrun_01M0K0CA9N5P7C5G1CG01MMHH6
thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01M0K0CFZPW29D9ZA744AM3X7M
customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01M0K0CPZJXA8ZDW8WRRWGPGCC
instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01M0K0CXT4AVGN853Z4GT2PCPW
crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01M0K0D8Z0F4Z8723TSC2SV45D
stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01M0K0DH4H820CP8G5Y1DQP91X
cancelRun - cancelling a running workflow | wrun_01M0K0DR0X92MWM17P12XCEZTF
cancelRun via CLI - cancelling a running workflow | wrun_01M0K0DWPA653YKGG4M45VSVJE
pages router addTenWorkflow via pages router
pages router promiseAllWorkflow via pages router
pages router sleepingWorkflow via pages router
hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01M0K0E4G3JGB456VQKT6B9QC1
hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01M0K0EFX5FTP3WTF8SPP37MDZ
sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01M0K0ERGNZRMG6Y010MRD4HCC
sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01M0K0F2ZH7JVRXY39EN2W5JFD
importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01M0K0F9M5FPF9TSTQGGEB31K5
metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01M0K0FBV5JKGT941N0JFFKYB2
resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01M0K0FE1J8VP6EVDKYS0HXYT0

Details by Category

✅ ▲ Vercel Production

App	Passed	Skipped
✅ astro	99	8
✅ example	99	8
✅ express	99	8
✅ fastify	99	8
✅ hono	99	8
✅ nextjs-turbopack	104	3
✅ nextjs-webpack	104	3
✅ nitro	99	8
✅ nuxt	99	8
✅ sveltekit	99	8
✅ vite	99	8

✅ 💻 Local Development

App	Passed	Skipped
✅ astro-stable	101	6
✅ express-stable	101	6
✅ fastify-stable	101	6
✅ hono-stable	101	6
✅ nextjs-turbopack-canary	88	19
✅ nextjs-turbopack-stable	107	0
✅ nextjs-webpack-canary	88	19
✅ nextjs-webpack-stable	107	0
✅ nitro-stable	101	6
✅ nuxt-stable	101	6
✅ sveltekit-stable	101	6
✅ vite-stable	101	6

✅ 📦 Local Production

App	Passed	Skipped
✅ astro-stable	101	6
✅ express-stable	101	6
✅ fastify-stable	101	6
✅ hono-stable	101	6
✅ nextjs-turbopack-canary	88	19
✅ nextjs-turbopack-stable	107	0
✅ nextjs-webpack-canary	88	19
✅ nextjs-webpack-stable	107	0
✅ nitro-stable	101	6
✅ nuxt-stable	101	6
✅ sveltekit-stable	101	6
✅ vite-stable	101	6

✅ 🐘 Local Postgres

App	Passed	Skipped
✅ astro-stable	101	6
✅ express-stable	101	6
✅ fastify-stable	101	6
✅ hono-stable	101	6
✅ nextjs-turbopack-canary	88	19
✅ nextjs-turbopack-stable	107	0
✅ nextjs-webpack-canary	88	19
✅ nextjs-webpack-stable	107	0
✅ nitro-stable	101	6
✅ nuxt-stable	101	6
✅ sveltekit-stable	101	6
✅ vite-stable	101	6

✅ 🪟 Windows

App	Passed	Failed	Skipped
✅ nextjs-turbopack	107	0	0

❌ 🌍 Community Worlds

App	Passed	Failed	Skipped
✅ mongodb-dev	4	0	3
✅ redis-dev	4	0	3
❌ redis	68	20	0
✅ turso-dev	4	0	3
❌ turso	3	85	0

✅ 📋 Other

App	Passed	Skipped
✅ e2e-local-dev-nest-stable	101	6
✅ e2e-local-dev-tanstack-start-stable	101	6
✅ e2e-local-postgres-nest-stable	101	6
✅ e2e-local-postgres-tanstack-start-stable	101	6
✅ e2e-local-prod-nest-stable	101	6
✅ e2e-local-prod-tanstack-start-stable	101	6

📋 View full workflow run

pranaygp · 2026-08-21T23:59:14Z

Converting to draft so we can confirm that it doesn't cause regression in main beta branch before we re confident about rolling this backport over to stable

[core] Keep step results ordered behind waits parked on unread hook p…

dc97a73

…ayloads (#3406) (cherry picked from commit fbebf71) # Conflicts: # packages/core/src/delivery-barrier-coverage.test.ts # packages/core/src/private.ts

vercel Bot deployed to Preview – workflow-docs August 21, 2026 20:22 View deployment

VaguelySerious mentioned this pull request Aug 21, 2026

[core] Pin correlation-id draw order to event-log order (#3700) (backport to stable) #3719

Draft

vercel Bot deployed to Preview – workflow-web August 21, 2026 20:22 View deployment

vercel Bot deployed to Preview – workflow-tarballs August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – workbench-nitro-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – workbench-express-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – workbench-nestjs-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – example-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – workbench-fastify-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – workbench-hono-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – workbench-astro-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – workbench-vite-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – workbench-tanstack-start-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – workbench-sveltekit-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – workbench-nuxt-workflow August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – example-nextjs-workflow-turbopack August 21, 2026 20:23 View deployment

vercel Bot deployed to Preview – example-nextjs-workflow-webpack August 21, 2026 20:24 View deployment

vercel Bot deployed to Preview – workflow-swc-playground August 21, 2026 20:25 View deployment

VaguelySerious mentioned this pull request Aug 21, 2026

[.github] Point manual-backport instructions at the input the dialog shows #3720

Draft

VaguelySerious marked this pull request as ready for review August 21, 2026 20:31

VaguelySerious requested review from a team and ijjk as code owners August 21, 2026 20:31

pranaygp marked this pull request as draft August 21, 2026 23:59

Navigation Menu

Uh oh!

[core] Keep step results ordered behind waits parked on unread hook payloads (#3406) (backport to stable) - #3718

[core] Keep step results ordered behind waits parked on unread hook payloads (#3406) (backport to stable)#3718
VaguelySerious wants to merge 1 commit into
stablefrom
backport/pr-3406-to-stable

VaguelySerious commented Aug 21, 2026

Uh oh!

vercel Bot commented Aug 21, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026 •

edited

Loading

Uh oh!

pranaygp commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

VaguelySerious commented Aug 21, 2026

Why this is on stable's critical path

Adaptations

Verification

Uh oh!

vercel Bot commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Aug 21, 2026

🦋 Changeset detected

Uh oh!

github-actions Bot commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 E2E Test Results

Summary

❌ Failed Tests

Details by Category

Uh oh!

pranaygp commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Aug 21, 2026 •

edited

Loading

github-actions Bot commented Aug 21, 2026 •

edited

Loading