[core] Pin correlation-id draw order to event-log order (#3700) (backport to stable) - #3719
Draft
VaguelySerious wants to merge 1 commit into
Draft
[core] Pin correlation-id draw order to event-log order (#3700) (backport to stable)#3719VaguelySerious wants to merge 1 commit into
VaguelySerious wants to merge 1 commit into
Conversation
(cherry picked from commit 9b1b8c7)
🦋 Changeset detectedLatest commit: cbe086c The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (105 failed)redis (20 failed):
turso (85 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
VaguelySerious
marked this pull request as ready for review
August 21, 2026 20:31
pranaygp
marked this pull request as draft
August 21, 2026 23:57
Contributor
|
Converting to draft so we can confirm that it doesn't cause regression in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #3700 (cherry-pick
9b1b8c71) tostable. The automated job could not do it: everyBackport to stablerun since 2026-08-21 18:31 fails because the AI Gateway key is over its budget (API key budget exceeded. Current spend: $10001.21, limit: $10000.00), including the forcedworkflow_dispatchrun, which resolved the SHA and cherry-picked correctly before dying at conflict resolution.Stacked on #3718 (backport of #3406), which this commit cannot terminate without. Merge that first; this PR's diff is against it.
Why the prerequisite
#3700's turnstile waits on any lower armed barrier, a wider relation than
gatesOn, and its deadlock-freedom argument rests on #3406 having removedcomputeResolvesOnItsOwn's unconditionalstep -> trueshortcut. Cherry-picked onto plainstable, this commit's own turnstile termination pin fails withUnconsumed event: step_created: the step spinner is reported self-resolving, sohasParkedCommittedDeliveryblocks the dispenser and the parked chain never opens.Adaptations
workflow.ts:stablehas nogenerateUlidconst and installs the rawulidfactory as theSTABLE_ULIDglobal (upstream installs the countinggenerateUlid). Wrapped ascountingUlid(seedTime?), preserving the factory signature, somintCountcounts every draw from the run's sequence including serialization-driven stream ids (the termination argument forquiesceEarlierCascadesdepends on that) without changing which seed time stream ids get onstable.private.ts: thegatesOndoc hunk carries over via [core] Keep step results ordered behind waits parked on unread hook payloads (#3406) (backport to stable) #3718.isLogOrderDrawsEnabled,quiescenceTurn,quiesceEarlierCascadesandawaitEarlierDeliveriesare byte-identical tomain.test-support/orchestrator-context.tsdoes not exist onstable(that extraction ismain-only) and is dropped. ThemintCountwiring it carries applies to the localsetupWorkflowContextcopies in the four test files the commit already touches, which is where the cherry-pick put it.docs/content/docs/v5/configuration/runtime-tuning.mdxdoes not exist onstable, whose docs tree has nov5/configurationdirectory. Dropped, matching Backport #3554: [core] Pin draw order to event-log order: retire delivery barriers through one ordered dispenser #3629 which carried no docs files for the same reason.WORKFLOW_LOG_ORDER_DRAWSstays documented onmain..gitignore: took only this commit's addition (thee2e-diagnostics-*.jsonsidecar entry, whose writer does exist onstable), not themain-onlyevent-log-race-repro-*block the conflict dragged in.minor->patchfor the maintenance line, matching Backport #3554: [core] Pin draw order to event-log order: retire delivery barriers through one ordered dispenser #3629.Verification
packages/coreunit suite green in both flag modes: 859 passed / 3 expected fail / 3 skipped with the flag default-on, and identical withWORKFLOW_LOG_ORDER_DRAWS=0. The turnstile termination pin that fails without [core] Keep step results ordered behind waits parked on unread hook payloads (#3406) (backport to stable) #3718 passes here.@workflow/corebuild (tsc) clean.Not run locally: the e2e lanes (they need a built workbench) and the
Event Log Race Reprolane, which is the measurement that matters for this change. CI on this PR is the check.