test: add coverage for manifest Validate - #17
Merged
jim-junior merged 1 commit intoSep 22, 2026
Merged
Conversation
Validate had no tests despite being the entry point that catches malformed manifests before a run starts, covering runtime/experiment presence, duplicate runtime names, port ranges, volume fields, and the cpu and http-readiness experiment specific checks. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed: adds unit tests for internal/manifest.Validate.
Why: Validate is the entry point that catches malformed manifests before a run starts, but had no tests. Added coverage for runtime and experiment presence checks, duplicate runtime names, port range validation, volume field validation, and the cpu and http-readiness experiment specific checks.
How it was tested: go build, go vet, and go test all pass locally.