test: add coverage for plan Generate - #18
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
Generate combines runtimes and experiments into the trial plan that drives the whole harness run, but had no tests for the default versus other workload precedence, the unknown runtime error path, or trial ID slugification. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
Collaborator
|
Hello @magic-peach Considering this PR and PR #17 are concerned with testing. I have added a testing CI github action in PR #19 . Please rebase this PR to main so that the workflow checks can be run on this PR too. Do the same for PR #17 too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed: adds unit tests for internal/plan.Generate.
Why: Generate combines runtimes and experiments into the trial plan that drives the whole harness run, but had no tests for the default versus other workload precedence, the unknown runtime error path, or trial ID slugification.
How it was tested: go build, go vet, and go test all pass locally.