Preserve explicit ground connections instead of redundant GND branches - #932
Open
imrishabh18 wants to merge 3 commits into
Open
Preserve explicit ground connections instead of redundant GND branches#932imrishabh18 wants to merge 3 commits into
imrishabh18 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Base automatically changed from
codex/repro-pga300-redundant-ground-traces
to
main
August 26, 2026 11:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
main→codex/repro-pga300-redundant-ground-traces)main.Fix
The global ground spanning tree replaced the explicit PGA300 COMP–R1 wire with nearby COMP–U1.GND and COMP–C3 ground branches.
isGroundmetadata already supplied by core.Before / after
Before (#930)
After
Validation
bun test: 225 passed, 4 existing skips, 0 failures.bunx tsc --noEmit,bun run build, focused formatting, andgit diff --check: passed.Integration limitation
The full core render also shows an extra automatically generated GND label beside the manually placed upper GND label. Handling that manual/automatic-label duplication is outside this solver routing fix; this is not a claim of pixel-perfect reference matching.