馃悰 fix(api): build site paths from site lists - #604
Merged
gaborbernat merged 3 commits intoSep 29, 2026
Merged
Conversation
gaborbernat
changed the title
gaborbernat
enabled auto-merge (squash)
September 29, 2026 16:39
The base site_applications_path split site_applications_dir on os.pathsep under multipath. Outside Unix and macOS that value is one path, so a name holding the separator got cut, and Android with appname="a:b" gave files/a. The Windows override in this PR left Android and iOS broken. Each site kind that can span several directories now has a list in the base class, defaulting to its single *_dir, and the base *_path and iter_*_dirs read that list. Unix and macOS supply their search paths and drop their own copies, so no accessor parses a joined string. isolated_dirs restores the base lists, which then follow the redirected dirs for every kind.
gaborbernat
force-pushed
the
fix/windows-applications-path-semicolon
branch
from
September 29, 2026 16:46
b2ec920 to
d2b388c
Compare
gaborbernat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
multipath=Truethe basesite_applications_pathsplitsite_applications_dironos.pathsepfor every platform. Outside Unix and macOS that value is one directory, so a name holding the separator got cut. Windows turnedC:\Programs;SharedintoC:\Programs, and Android withappname="a:b"returned/data/data/<package>/files/a. 馃悰 The first version of this PR fixed Windows alone.Each site kind that can span several directories (data, config, cache and applications) now has a list in the base class that defaults to its single
*_dir. The base*_pathanditer_*_dirsread that list. 馃敡 Unix and macOS supply their search paths and drop their own copies of those accessors, so no accessor parses a joined string anymore.platformdirs.testing.isolated_dirsrestores the base lists, which then follow the redirected directories for every kind.Unix and macOS results do not change, since each entry there comes from a list split on
os.pathsepand cannot contain it. An OpenAI Codex agent wrote the original Windows patch at the account owner's request.