♻️ refactor(api): share use_site iteration - #606
Merged
Merged
Conversation
Unix overrode all six _iter_*_dirs only to skip the user dir as root with use_site_for_root, while tox-dev#604 moved the rest of the iteration into the base class. The base iterators now carry that skip behind _use_site, which returns False outside Unix, so the overrides go. Results do not change on any platform.
gaborbernat
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #604 moved site path and list handling into the base class, Unix still overrode all six
_iter_*_dirsmethods. ♻️ Each copy differed from the base in one condition. As root withuse_site_for_root, it skipped the user directory.That condition now lives in the base iterators behind
_use_site, which staysFalseeverywhere except Unix, where it checks for uid 0. Runtime keeps its inverted rule. Root drops the site directory there, becausesite_runtime_dirreads the invoking user'sXDG_RUNTIME_DIR.No platform yields different directories, hence
skip news.