Skip to content

fix(sdk): Node 24 SDK extraction + restore green CI matrix #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janvennemann wants to merge 3 commits into from
+10 −15
Closed

fix(sdk): Node 24 SDK extraction + restore green CI matrix #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89684dc
ci: pin pnpm version
janvennemann May 22, 2026
e97296d
test(sdk): stabilize branch-list assertion
janvennemann Jun 16, 2026
b626ea1
fix(sdk): upgrade yauzl to 3.4.0 for Node 24 SDK extraction
janvennemann Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ jobs:

- name: Install pnpm
uses: pnpm/action-setup@v4
with:
version: latest

- name: Install dependencies
run: pnpm install
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "titanium",
"version": "8.1.5",
"packageManager": "pnpm@10.33.3",
"author": "TiDev, Inc. <npm@tidev.io>",
"description": "Command line interface for building Titanium SDK apps",
"type": "module",
Expand Down Expand Up @@ -33,7 +34,7 @@
"which": "6.0.1",
"wrap-ansi": "10.0.0",
"xpath": "0.0.34",
"yauzl": "3.3.0"
"yauzl": "3.4.0"
},
"devDependencies": {
"@reporters/github": "1.13.1",
Expand Down
16 changes: 5 additions & 11 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion test/commands/ti-sdk.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,9 @@ describe('ti sdk', () => {
({ exitCode, stdout } = await run(['sdk', 'ls', '-bu', '--json']));
const json = JSON.parse(stdout);
assert(json.branches.branches.includes('main') || json.branches.branches.includes('master'));
assert(json.branches.branches.includes('12_6_X'));
// Assert a version-line branch exists rather than a specific one; the
// live branch list changes as the SDK release line advances.
assert(json.branches.branches.some(branch => /^\d+_\d+_X$/.test(branch)));
assert(json.releases[sdkName]);

assert.strictEqual(exitCode, 0);
Expand Down
Loading