fix(sdk): Node 24 SDK extraction + restore green CI matrix#952
Open
janvennemann wants to merge 3 commits into
Open
fix(sdk): Node 24 SDK extraction + restore green CI matrix#952janvennemann wants to merge 3 commits into
janvennemann wants to merge 3 commits into
Conversation
This was referenced Jun 16, 2026
Closed
The `sdk list` test hardcoded `branches.includes('12_6_X')`, asserting a
specific branch exists in the live build-server branch list. That branch has
since been removed (current version-line branches are 11_1_X, 12_7_X, 13_0_X,
12_8_X, 13_1_X, 13_2_X), so the assertion fails and breaks CI on every branch.
Assert that at least one version-line branch (`\d+_\d+_X`) is present instead,
which verifies branch listing works without coupling to a volatile branch name.
janvennemann
changed the title
On Node 24, yauzl 3.3.0's internally-piped inflate stream produces no output for larger deflate entries: `openReadStream` returns a stream that never emits data or 'end'. During `ti sdk install` this stalls extraction at the first big file (e.g. lodash.js, 544 KB) — `readEntry()` is never called again, the event loop drains, and Node 24 aborts with "Detected unsettled top-level await". The SDK never finishes installing. Node 20/22 are unaffected. yauzl 3.4.0 fixes the inflate-stream composition. Verified: `ti sdk install 12.2.0.GA` completes on Node 24 and lodash.js extracts to its full 544098 bytes. 3.4.0 drops the buffer-crc32 dependency; lockfile updated surgically (yauzl bump + buffer-crc32 removal only), frozen-install verified consistent.
janvennemann
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes to get the test matrix green again across Node 20/22/24. The CI matrix was fully red; root causes were unrelated.
1.
fix(sdk): upgrade yauzl 3.3.0 → 3.4.0 (Node 24 SDK extraction) — user-facing bugOn Node 24, yauzl 3.3.0's internally-piped inflate stream produces no output for larger deflate entries —
openReadStreamreturns a stream that never emitsdata/end. Duringti sdk install, extraction stalls at the first big file (lodash.js, 544 KB):readEntry()is never called again, the event loop drains, and Node 24 aborts with "Detected unsettled top-level await". The SDK never finishes installing on Node 24. Node 20/22 are unaffected (which is why only Node 24 CI failed).yauzl 3.4.0 fixes the inflate-stream composition. Verified end-to-end:
ti sdk install 12.2.0.GAcompletes on Node 24 andlodash.jsextracts to its full 544098 bytes. Lockfile updated surgically (yauzl bump + the now-unusedbuffer-crc32removal only);--frozen-lockfileverified consistent.2.
ci: pin pnpm (packageManager: pnpm@10.33.3, dropversion: latest)action-setup@v4 + version:latestresolved pnpm 11.x (needs Node ≥22.13 /node:sqlite); the Node 20 matrix crashed duringpnpm install. Pinning to pnpm 10.33.3 restores installs.3.
test(sdk): stabilize thesdk listbranch assertionHardcoded
branches.includes('12_6_X')— that branch was removed from the live server (current:11_1_X, 12_7_X, 13_0_X, 12_8_X, 13_1_X, 13_2_X). Now asserts any\d+_\d+_Xversion-line branch.Notes
8.1.5. Supersedes ci: pin pnpm version #947.maininto feat: add serve command support #910.