Skip to content

Scroll to the fastest node after sorting by test result #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mahdi-zarei merged 3 commits into from
Nov 13, 2026
Merged

Scroll to the fastest node after sorting by test result #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eae7be
Update callbacks in TestPanelController
Fasdeq13 Nov 9, 2026
96f53bd
Add onVisibilityChanged callback in TestPanelController
Fasdeq13 Nov 9, 2026
3ab5816
Implement revealSorted method in ConfigurationFragment
Fasdeq13 Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/src/main/java/io/nekohasekai/sagernet/ui/ConfigurationFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ class ConfigurationFragment : ToolbarFragment(R.layout.layout_group_list),
if (!select) {
testPanel = TestPanelController(this, panelContainer, side = sidePanel).apply {
onSelectProfile = { id -> selectProfile(id, toggleOnTv = false) }
onSorted = { groupId, id -> revealSorted(groupId, id) }
onHeightChanged = { height ->
if (height != panelHeight) {
panelHeight = height
Expand Down Expand Up @@ -413,6 +414,16 @@ class ConfigurationFragment : ToolbarFragment(R.layout.layout_group_list),
}
}

/** After a sort from the test panel: brings the group's fastest profile into view once the new order is shown. */
private fun revealSorted(groupId: Long, profileId: Long) {
val owner = viewLifecycleOwnerLiveData.value ?: return
owner.lifecycleScope.launch {
val list = listFor(groupId) ?: return@launch
list.adapter.reload()?.join()
if (query.isEmpty() && !selection.active) list.revealProfile(profileId)
}
}

/** The navigation icon in the toolbar's colours (the white theme draws it dark, as ToolbarFragment does). */
private fun setNavigationIcon(@DrawableRes icon: Int, @StringRes description: Int) {
val toolbar = toolbar ?: return
Expand Down
5 changes: 5 additions & 0 deletions app/src/main/java/io/nekohasekai/sagernet/ui/test/TestPanelController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ class TestPanelController(
/** Selects a profile like a tap in the list; by default the panel selects it and reloads a running service. */
var onSelectProfile: ((profileId: Long) -> Unit)? = null

/** Called with the group and its fastest profile once a sort from the panel has been written. */
var onSorted: ((groupId: Long, profileId: Long) -> Unit)? = null

/** Called when the panel starts to appear, and when it has gone (after sliding out). */
var onVisibilityChanged: ((visible: Boolean) -> Unit)? = null

Expand Down Expand Up @@ -844,6 +847,7 @@ class TestPanelController(
if (groupId <= 0) return
val bySpeed = s.kind == TestSpec.KIND_SPEED && !s.countryMode
val upload = s.speedMode == TestUiState.SPEED_MODE_UPLOAD
val fastest = s.ranking.firstOrNull()?.profileId
runOnDefaultDispatcher {
val sorted = if (bySpeed) {
// Kept like the latency sort, so the next stored result re-sorts instead of undoing the order.
Expand All @@ -855,6 +859,7 @@ class TestPanelController(
onMainDispatcher {
if (fragment.isAdded) {
fragment.snackbar(if (sorted) R.string.test_panel_sorted else R.string.test_panel_sort_busy).show()
if (sorted && fastest != null) onSorted?.invoke(groupId, fastest)
}
}
}
Expand Down