Repository navigation
Scroll to the fastest node after sorting by test result - #136
Merged
Merged
Conversation
Replaced onVisibilityChanged with onSorted callback to handle sorting events.
Added a callback for visibility changes of the panel.
Added a method to reveal the sorted profile after sorting in the test panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134.
Previously, when the list was sorted based on URL test results, it would remain in its current position; users had to manually scan the list to find the fastest server (which would now be at the top, but might be out of view if the user was further down the list).
Now, after sorting from the test panel, the list waits to reload in the new order and then automatically scrolls to the fastest node. If the search bar is open or an item is currently selected, no scrolling occurs, ensuring the user's context is not disrupted.
Changes were made to two files:
TestPanelController(via theonSortedcallback) andConfigurationFragment(addingrevealSorted, which leverages the existingrevealProfilemethod).