fix(ci): unblock all jobs (scip-go, RealIP, lucide v1, plugin-react v6, tailwind v4, linters)#28
Merged
Merged
Conversation
lucide-react v1.x removed brand logos (Github, Gitlab, etc.) for trademark reasons. The dependabot bump from 0.555 to 1.11 in #19 made ConnectionsClient.tsx fail to compile. Add small inline SVG components for GithubIcon and GitlabIcon, matching the existing CodeSearchIcon.tsx pattern (currentColor fill, className prop). The other lucide imports are unaffected. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
Two more breakages from the dependabot bump in #19: @vitejs/plugin-react 6.x peers on vite ^8, but vitest pulls vite ^7, so the lockfile resolves vite 7.3.1 and plugin-react 6 fails on vitest startup with 'Package subpath ./internal is not defined'. Pin to ^5.2.0 (peers on vite 4-8 inclusive). No behavior change for the React plugin itself; just removes the peer conflict. tailwindcss 4.x is a major rewrite (new @import directive, new config model, breaking utility-class changes) and the project's CSS still uses v3 syntax. The full v4 migration is a separate deliberate effort; revert to ^3.4.19 for now to unblock CI. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
Upstream renamed the module from github.com/sourcegraph/scip-go to github.com/scip-code/scip-go. Installing via @latest under the old path now fails the go.mod path check. Switch to the new canonical path; the cmd subpath and resulting binary name are unchanged. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
aanogueira
changed the title
3 tasks
aanogueira
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All pre-existing CI failures consolidated. Originally split as #27 (scip-go) + #28 (web deps); now bundled here so one CI run proves the full picture. Closes #27.
None of these are caused by #26 (deploy-website) — they would fail any PR.
Go
1. `indexer-scip` Dockerfile — upstream module rename
go install github.com/sourcegraph/scip-go/cmd/scip-go@latestfails because upstream moved to thescip-codeorg. Switch togithub.com/scip-code/scip-go/cmd/scip-go@latest.2. `chi` middleware.RealIP deprecated (GHSA-3fxj-6jh8-hvhx + 2 others)
Replace with a new `internal/middleware.RealIP` that only honors X-Forwarded-For when the immediate TCP peer is in a configured trusted-proxy CIDR set.
3. `gomodguard` linter renamed to `gomodguard_v2` in
.golangci.yml.Web
4. `lucide-react` 0.x → 1.x removed brand logos
Github/Gitlabicons no longer exist (trademark/licensing). Addweb/components/GithubIcon.tsx+GitlabIcon.tsx(inline SVGs matching the existingCodeSearchIcon.tsxpattern), updateConnectionsClient.tsx.5. `@vitejs/plugin-react` 5 → 6 peer mismatch
Plugin-react 6 peers on
vite ^8, lock has vite 7 → vitest startup error. Pin to^5.2.0(peers 4–8 inclusive). No functional change.6. `tailwindcss` 3 → 4 breaking change
Major rewrite — new
@importdirective, new config model, breaking utility-class changes. Revert to^3.4.19; v4 migration is its own deliberate PR.Verification (locally on this branch)
go build ./...✓go test ./internal/middleware/... ./internal/config/...— 33 pass ✓golangci-lint run ./...— no issues ✓bun run build(web) ✓bun run test:run(web) — 71 tests ✓bun run lint(web) — only pre-existing warnings ✓Test plan
docker-buildjobs passgo-checkspasses (lint + tests)web-checkspassesFollow-ups (separate PRs)
server.trusted_proxiesin production config