fix(ci): unblock docker-build jobs (scip-go rename + web lockfile)#27
Closed
aanogueira wants to merge 2 commits into
Closed
fix(ci): unblock docker-build jobs (scip-go rename + web lockfile)#27aanogueira wants to merge 2 commits into
aanogueira wants to merge 2 commits into
Conversation
Upstream renamed the module from github.com/sourcegraph/scip-go to github.com/scip-code/scip-go. Installing via @latest under the old path now fails the go.mod path check. Switch to the new canonical path; the cmd subpath and resulting binary name are unchanged. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
The lockfile had drifted from package.json (likely from a dependabot bump that updated one without the other). The web Dockerfile uses --frozen-lockfile, so the drift broke the docker-build CI job. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
Merged
4 tasks
Contributor
Author
|
Superseded by #28 — scip-go fix is now bundled there along with three other dependabot-bump-fallout fixes, so all CI goes green in one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated CI breakages currently failing
docker-buildjobs onmain. Fixing both here so the pipeline goes green; the in-flight #26 (GitHub Pages deploy) can rebase onto this once merged.1.
docker/indexer-scip.DockerfileUpstream renamed the module from
github.com/sourcegraph/scip-gotogithub.com/scip-code/scip-go. The Dockerfile pins@latest, which now resolves to a tag whosego.moddeclares the new path — Go refuses the path mismatch.Fix: switch the install path. The
cmd/scip-gosubpath and output binary name are unchanged, so theCOPY --from=scip-go-builder /go/bin/scip-go ...line still works.2.
web/bun.lockLockfile had drifted from
package.json(likely a dependabot bump that touched one without the other). The web Dockerfile uses--frozen-lockfile, so install fails.Fix: regenerate via
bun installand verifybun install --frozen-lockfileis clean.Test plan
docker-build (docker/indexer-scip.Dockerfile, code-search-indexer-scip)passesdocker-build (docker/web.Dockerfile, code-search-web)passes