Skip to content

fix: don't emit empty <dataAccelerationConfig/> on workbook update when unset #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacalata wants to merge 1 commit into
base: development
Choose a base branch
from
+18 −2
Open

fix: don't emit empty <dataAccelerationConfig/> on workbook update when unset #1885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tableauserverclient/server/request_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,8 +1077,11 @@ def update_req(self, workbook_item, parent_srv: "Server | None" = None):
views_element = ET.SubElement(workbook_element, "views")
for view in workbook_item.views:
_add_view_element(views_element, view.id)
if workbook_item.data_acceleration_config:
data_acceleration_config = workbook_item.data_acceleration_config
data_acceleration_config = workbook_item.data_acceleration_config
if data_acceleration_config and (
data_acceleration_config.get("acceleration_enabled") is not None
or data_acceleration_config.get("accelerate_now") is not None
):
data_acceleration_element = ET.SubElement(workbook_element, "dataAccelerationConfig")
if data_acceleration_config["acceleration_enabled"] is not None:
data_acceleration_element.attrib["accelerationEnabled"] = str(
Expand Down
13 changes: 13 additions & 0 deletions test/test_workbook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,19 @@ def test_update(server: TSC.Server) -> None:
assert not single_workbook.data_acceleration_config["accelerate_now"]


def test_update_excludes_data_acceleration_config_when_unset(server: TSC.Server) -> None:
"""dataAccelerationConfig should be omitted from the update request XML when never set."""
response_xml = UPDATE_XML.read_text()
with requests_mock.mock() as m:
m.put(server.workbooks.baseurl + "/1f951daf-4061-451a-9df1-69a8062664f2", text=response_xml)
single_workbook = TSC.WorkbookItem("1d0304cd-3796-429f-b815-7258370b9b74", show_tabs=True)
single_workbook._id = "1f951daf-4061-451a-9df1-69a8062664f2"
server.workbooks.update(single_workbook)
request_body = m.request_history[0].body
xml_root = fromstring(request_body)
assert xml_root.find(".//dataAccelerationConfig") is None


def test_update_description_in_request_xml(server: TSC.Server) -> None:
"""description should be included in the update request XML when server >= 3.21."""
server.version = "3.21"
Expand Down
Loading