Skip to content

test: pause the clock so the logs poll check cannot race close #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilyaZar merged 1 commit into from
Oct 30, 2026
Merged

test: pause the clock so the logs poll check cannot race close #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/logs.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ test('logs render literal text, update logging levels and cancel polling on clos
syncthing,
}) => {
syncthing.configure();
await page.clock.install();
// Paused time keeps a 2 s poll from landing between Close and the count.
const start = new Date('2026-09-08T12:00:00Z');
await page.clock.install({ time: start });
await page.clock.pauseAt(start);
let levels = { api: 'INFO' },
writes = 0,
reads = 0;
Expand Down Expand Up @@ -49,9 +52,13 @@ test('logs render literal text, update logging levels and cancel polling on clos
dialog.getByRole('combobox', { name: 'api', exact: true }),
).toHaveValue('WARN');
expect(writes).toBe(1);
await page.clock.runFor(2200);
await expect.poll(() => reads).toBe(2);
await dialog.getByRole('button', { name: /Close/ }).click();
await expect(dialog).toHaveCount(0);
const before = reads;
await page.clock.runFor(2200);
// A late poll needs a round trip before the route counts it.
await page.waitForTimeout(500);
expect(reads).toBe(before);
});
Loading