Repository navigation
test: pause the clock so the logs poll check cannot race close - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev run after #5 failed in
tests/logs.spec.mjs(expected 1 log read after close, got 2) with code identical to the passing PR head.page.clock.install()lets time flow, so on a slow runner the 2 s poll fires around the Close click and its request reaches the route after the test has taken its countuseLogTail(verified locally, it now fails with 2 vs 3)Local: 20/20 repeated runs pass; lint, types and unit tests pass.