Repository navigation
feat: publish a semantic host palette contract - #5
Merged
Merged
Conversation
- material you shells export semantic roles, not terminal colors - the contract maps each template token to a role, so hosts stop hard-coding it - the contrast suite covers dux shell's default theme in dark and light mode Closes #4
the browser suite needs about four minutes, but setup has run past the old limit
the ubuntu runner already ships chrome's libraries; the apt step alone took over twelve minutes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4.
Changes
integration/host-palette.json: the 12 semantic roles a Material You shellsupplies and, per template token, the role that fills it. The mapping equals
the one the Syncshell plugin hard-codes today, so switching the plugin to it
changes no rendered output.
tests/host-palette.test.mjs: the contract resolves every placeholder ofomarchy-theme.css.inexactly once and uses every role.tests/omarchy-contrast.spec.mjs: Dux Shell's default purple theme (dark andlight), mapped through the contract, runs the existing contrast and
palette-refresh checks. In light mode the refresh helper keeps the dark
foreground on the fixed Material success, warning and danger fills; that is
recorded like the other light palettes.
Checks
npm test: 83 passed.tests/omarchy-contrast.spec.mjs: 49 passed, including the four new runs.tscand Prettier pass; no shell script changed.Compatibility
Additive: the release keeps
integrationFormat: 1, and the plugin importeronly requires the existing files.