Bump version to 4.2.3#290
Conversation
### Fixed - multi-review: fix v2 session-resume restoring only a fraction of bundles on PRs with many reviewers. Two compounding bugs in session-resume.ts caused 2/7 bundles restored on 7-reviewer PRs, empty reviewer output, and forced CANNOT MERGE. PR #289.
Svitter
left a comment
There was a problem hiding this comment.
Rank: P3 (already landed). This PR was merged to main as e4b8168 and v4.2.3 is pushed, so this review is a post-merge confirmation only.
Diff scope: 2 files, 10+/1- — CHANGELOG.md and multi-review/package.json (4.2.2 → 4.2.3). The bump correctly publishes the v2 session-resume fix from #289, and the CHANGELOG entry accurately summarizes the two compounding bugs (bootstrap file-vs-migration readiness, concurrent opencode import racing non-idempotent DDL) and the serial-import + serve-ready-line fix. Conventions from docs/release-process.md and AGENTS.md are followed: setup-opencode/default-version is left untouched, and review-context-server/package.json is correctly left alone (it is versioned independently at 1.0.0).
No inline findings — the diff is mechanical and clean.
Post-merge follow-up (out of PR scope, for the maintainer): the v4 major tag is still pointing at v4.2.2 (0ddf321); step 5 of docs/release-process.md requires git tag -f v4 v4.2.3 && git push origin v4 --force so consumers pinned to @v4 pick up the fix.
Thanks @Svtter for the clean release prep.
Release 4.2.3
Fixed
multi-review: fix v2 session-resume restoring only a fraction of bundles on PRs with many reviewers (fix(multi-review): serial import + wait for serve ready line #289). On PRs with 7 reviewers, only 2/7 bundles imported successfully — the rest produced empty reviewer output, the coordinator reported "failed to complete", and multi-review forced CANNOT MERGE.
Two compounding bugs in
session-resume.ts:opencode.dbfile appearing for schema readiness (SQLite creates the file before migrations commit), killingopencode servemid-migration.opencode importcalls raced the non-idempotent migration DDL against the same SQLite DB; 5/7 died with "already exists".Fix: wait for
opencode serve's authoritativelistening on http://line and import bundles serially. Also replacesPromise.withResolverswith a Node 20-compatible helper, adds serve streamerrorhandlers, and caps captured serve output at 4KB.Tag
v4.2.3already pushed.