Skip to content

Bump version to 4.2.3#290

Merged
Svtter merged 1 commit into
mainfrom
release/4.2.3
Jun 28, 2026
Merged

Bump version to 4.2.3#290
Svtter merged 1 commit into
mainfrom
release/4.2.3

Conversation

@Svtter

@Svtter Svtter commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Release 4.2.3

Fixed

  • multi-review: fix v2 session-resume restoring only a fraction of bundles on PRs with many reviewers (fix(multi-review): serial import + wait for serve ready line #289). On PRs with 7 reviewers, only 2/7 bundles imported successfully — the rest produced empty reviewer output, the coordinator reported "failed to complete", and multi-review forced CANNOT MERGE.

    Two compounding bugs in session-resume.ts:

    • Bootstrap mistook the opencode.db file appearing for schema readiness (SQLite creates the file before migrations commit), killing opencode serve mid-migration.
    • Concurrent opencode import calls raced the non-idempotent migration DDL against the same SQLite DB; 5/7 died with "already exists".

    Fix: wait for opencode serve's authoritative listening on http:// line and import bundles serially. Also replaces Promise.withResolvers with a Node 20-compatible helper, adds serve stream error handlers, and caps captured serve output at 4KB.

Tag v4.2.3 already pushed.

### Fixed
- multi-review: fix v2 session-resume restoring only a fraction of
  bundles on PRs with many reviewers. Two compounding bugs in
  session-resume.ts caused 2/7 bundles restored on 7-reviewer PRs,
  empty reviewer output, and forced CANNOT MERGE. PR #289.
@Svtter
Svtter merged commit e4b8168 into main Jun 28, 2026
2 of 3 checks passed
@Svitter Svitter added chore Maintenance, tooling, and config changes review:p3 Nitpick / suggestions triaged Issue has been triaged labels Jun 28, 2026

@Svitter Svitter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rank: P3 (already landed). This PR was merged to main as e4b8168 and v4.2.3 is pushed, so this review is a post-merge confirmation only.

Diff scope: 2 files, 10+/1- — CHANGELOG.md and multi-review/package.json (4.2.24.2.3). The bump correctly publishes the v2 session-resume fix from #289, and the CHANGELOG entry accurately summarizes the two compounding bugs (bootstrap file-vs-migration readiness, concurrent opencode import racing non-idempotent DDL) and the serial-import + serve-ready-line fix. Conventions from docs/release-process.md and AGENTS.md are followed: setup-opencode/default-version is left untouched, and review-context-server/package.json is correctly left alone (it is versioned independently at 1.0.0).

No inline findings — the diff is mechanical and clean.

Post-merge follow-up (out of PR scope, for the maintainer): the v4 major tag is still pointing at v4.2.2 (0ddf321); step 5 of docs/release-process.md requires git tag -f v4 v4.2.3 && git push origin v4 --force so consumers pinned to @v4 pick up the fix.

Thanks @Svtter for the clean release prep.

@Svtter
Svtter deleted the release/4.2.3 branch June 28, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, tooling, and config changes review:p3 Nitpick / suggestions triaged Issue has been triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants