test: verify multi-review v4.2.3 session-resume fix#291
Conversation
Verify the v4.2.3 session-resume fix (serial import + serve ready line) works end-to-end in CI. This PR pins the workflow to @v4.2.3 so the multi-review run triggered by this very PR uses the fixed action. Previous runs used @v4.1.0 (buggy). Test-only; revert after verification.
|
无 🟡 警告项 / Warnings
🟢 建议项 / Suggestions
🟡 警告项 / Warnings (1)
🟢 建议项 / Suggestions (1)
💰 Review Cost — $0.0000
📋 各 Reviewer 详细审查结果quality可合并 / CAN MERGE PR 将 阻塞项:无 security存在风险 / AT RISK 该 PR 仅涉及 GitHub Actions 工作流中 阻塞项:无 警告项:
建议项:
performance性能良好 / GOOD 该 PR 仅将 阻塞项:无 警告项:无 建议项:无 architecture架构合理 / SOUND 本次 PR 仅将 阻塞项:无 警告项:无 建议项:无 regression-test无需回归测试 / NO REGRESSION TESTS NEEDED CHORE:PR 仅将 workflow 中引用的 action 版本从 阻塞项:无 test-value测试全部有价值 / ALL TESTS HAVE VALUE 该 PR 仅修改了
|
Svitter
left a comment
There was a problem hiding this comment.
Rank: P3 — single-line dogfood validation for an already-shipped fix; not a merge candidate.
Diff (.github/workflows/multi-review.yml:28): uses: sun-praise/opencode-actions/multi-review@v4.1.0 → @v4.2.3. Trivial and exactly what the body claims — no other files touched, no invariants disturbed.
Why P3, not P0/P1:
- The fix being validated (serial import + serve-ready wait, PR #289) already shipped via #290 (commit
e4b8168 Bump version to 4.2.3is onmain). - The PR body explicitly states "测试专用 PR,验证完不合入. 验证后会关闭并删分支" — author has already declared it test-only and the PR is closed.
- This is the same dogfood pattern as
539bc70 test: verify merged v2 session-resume fixes(later reverted via9aa4557); once verification succeeds, no merge is needed.
No findings. The bump is correct (v4.2.3 tag exists on main), the workflow body is otherwise untouched, and per the conventions a CHANGELOG.md entry is required only when a package is touched — this is a workflow-only change. Nothing to flag.
Thanks @Svtter — clean, well-scoped e2e validation. The 🔍 Multi-Review run on this branch is the actual deliverable, not the diff.
目的
用 PR 自身触发 `multi-review@v4.2.3`,端到端验证 v4.2.3 的 session-resume 修复(串行 import + 等 serve ready line)。
改动
把本仓库 `multi-review.yml` 的 action ref 从 `@v4.1.0` bump 到 `@v4.2.3`。这样这个 PR 触发的 multi-review run 就会用修复后的 action。
验证点
看 `🔍 Multi-Review` job 日志里的 `v2 resume:` 行: