Skip to content

Update C++ dependencies and simplify testing - #2

Merged
sean-parent merged 3 commits into
mainfrom
update-cpp-dependencies
Nov 19, 2026
Merged

sean-parent merged 3 commits into
mainfrom
update-cpp-dependencies

Conversation

@sean-parent

@sean-parent sean-parent commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Update cpp-library to 6.1.0 and cel-parser to 1.1.1; parser supplies cel-runtime 1.1.2 transitively.
  • Use cpp-library defaults and automatic license installation, and remove the custom source and installed consumer tests.
  • Initialize the shared installation option in cel-std before loading same-namespace dependencies.
  • Document separate, non-recursive installation of runtime, parser, and cel-std.
  • Include repository-specific Copilot instructions.

Test plan

  • cmake --preset=test && cmake --build --preset=test --parallel 2 && ctest --preset=test --output-on-failure --no-tests=error (2 tests and independent public-header compilation).
  • cmake --preset=clang-tidy && cmake --build --preset=clang-tidy --parallel 2 && ctest --preset=clang-tidy --output-on-failure --no-tests=error (2 tests).
  • Fresh Release configure/build/install, followed by the generated cpp-library-test-package.cmake check. Both installed license files match their sources.
  • Fresh configuration with explicit CEL_INSTALL=OFF preserves the installation opt-out.
  • cmake --preset=docs && cmake --build --preset=docs.
  • git diff --check.
  • GitHub CI at fbbfcbe: Ubuntu GCC, Ubuntu Clang, macOS, Windows, and clang-tidy passed; both tests ran in every job and installed-package artifact checks passed on all four platforms. The release-only docs job was skipped; documentation was built locally.

Generated with GitHub Copilot CLI

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos review

No issues found in the reviewed changes.

Reviewed commit: 2d0d56af2126323b4683d4e6e5444c833043c0a3, full PR diff against main (merge base 493acb275cc59cdcf802175d07c806aeefed8686). This is a comment-only review, not an approval.

Change overview and alignment

The dependency updates, use of cpp-library defaults, removal of custom consumer tests, and revised non-recursive installation instructions align with the PR title and description. No active OpenSpec context or base-commit project/custom instruction files were found.

Files Reviewers Candidates → validated → accepted Posted Overflow Tests
6 6 baseline personas + challenge 0 → 0 → 0 0 inline findings; summary review only 0 Local Debug configure/build and both CTest tests passed; Release configure/build/install and generated package-artifact check passed; diff whitespace check passed

All six personas returned valid empty observation arrays; the challenge reviewer confirmed the empty result. Existing PR review comments were checked: no duplicates or recurrences.

Verification limitations: the generated package check verifies installed artifacts, not compilation of a standalone installed consumer. No standalone installed-consumer test was run locally. Clang-tidy, documentation generation, and other platform builds were not rerun locally for this review. GitHub CI reports success for Ubuntu GCC, Ubuntu Clang, macOS, Windows, and clang-tidy; docs was skipped.

Persona routing: static roster (DCAP routing off; rerun with --dcap to enable).

Org knowledge: off (rerun with --knowledge).

Scout

Used: risk MEDIUM, evidence LOW, status COMPLETE (scout 0.9.135, <1s).
Cross-file leads given to reviewers: 0 changed symbol(s) with uses outside the diff, 0 new value(s) not handled everywhere, 2 possibly unused symbol(s).
Scout rated its evidence LOW for this change; reviewers used it only as leads.

sean-parent and others added 2 commits November 18, 2026 09:40
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use automatic license installation and initialize the shared install option before loading same-namespace dependencies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos review

No issues found in the reviewed changes.

Reviewed commit: fbbfcbe1dc5b62afc3eac0ba7c8402adf267dbe3, full PR diff against main (merge base 493acb275cc59cdcf802175d07c806aeefed8686). This refresh covers the dependency upgrades and Copilot instructions added after the earlier review. This is a comment-only review, not an approval.

Change overview and alignment

The branch updates cpp-library to 6.1.0 and cel-parser to 1.1.1 (cel-runtime 1.1.2 transitively), delegates license installation to cpp-library, initializes shared installation defaults before dependencies, removes custom consumer tests, updates installation documentation, and adds repository-specific Copilot instructions. The changes align with the PR title and description. No active OpenSpec context or base-commit project/custom instruction files were found.

Files Reviewers Candidates → validated → accepted Shown Overflow Tests
7 6 baseline personas + challenge 0 → 0 → 0 0 of 0 0 Exact-head CI verified; local documentation build and whitespace checks passed

All six personas returned valid empty observation arrays. The challenge pass accepted zero findings. Existing inline review comments were checked; there are no duplicates or recurrences.

Verification

Reused successful CI run 44472926044, pinned to the reviewed SHA, after inspecting every job and its logs:

  • Ubuntu GCC, Ubuntu Clang, macOS, and Windows each configured, built, and passed both CTest tests. Public-header compilation checks ran in every platform build.
  • All four platform jobs built, installed, and passed generated package-artifact checks.
  • The clang-tidy job configured and built with static analysis and passed both tests.
  • The release-only documentation job was skipped, so documentation was validated freshly on macOS with cmake --preset=docs && cmake --build --preset=docs (CMake 4.5.0, Ninja 1.13.2, Doxygen 1.18.0).
  • git diff --check main...HEAD and working-tree whitespace checks passed. The checkout is clean and matches the pushed PR head; no extra push or duplicate PR was needed.

Limitations: installed-package artifact checks verify generated files, not compilation of a standalone installed consumer. A standalone installed consumer was not run for this review. CI evidence was reused rather than rerunning the platform matrix locally. No new or changed C++ implementation files required a C++ formatting check.

Persona routing: static roster (DCAP routing off; rerun with --dcap to enable).

Org knowledge: off (rerun with --knowledge).

Scout

Used: risk MEDIUM, evidence LOW, status COMPLETE (scout 0.9.135, <1s).
Cross-file leads given to reviewers: 0 changed symbol(s) with uses outside the diff, 0 new value(s) not handled everywhere, 2 possibly unused symbol(s).
Scout rated its evidence LOW for this change; reviewers used it only as leads.

@sean-parent
sean-parent merged commit d7aea84 into main Nov 19, 2026
6 checks passed
@sean-parent
sean-parent deleted the update-cpp-dependencies branch November 19, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant