Skip to content

[6.x] Fix invalid ARIA in the command palette #15759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duncanmcclean merged 1 commit into from
Nov 2, 2026
Merged

[6.x] Fix invalid ARIA in the command palette #15759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions resources/js/components/command-palette/CommandPalette.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ router.on('start', () => Statamic.$commandPalette.clear());
</DialogTrigger>
<DialogPortal>
<DialogOverlay class="fixed inset-0 z-30 bg-gray-800/20 backdrop-blur-[2px] dark:bg-gray-800/50" />
<DialogContent :class="[modalClasses, $attrs.class]" data-ui-modal-content :aria-describedby="undefined">
<DialogContent :class="[modalClasses, $attrs.class]" data-ui-modal-content aria-modal="true" :aria-describedby="undefined">
<VisuallyHidden asChild>
<DialogTitle>{{ __('Command Palette') }}</DialogTitle>
</VisuallyHidden>
Expand Down Expand Up @@ -354,7 +354,7 @@ router.on('start', () => Statamic.$commandPalette.clear());
class="flex w-full bg-transparent py-4 text-lg antialiased outline-none placeholder:text-gray-500!"
/>
</header>
<ComboboxContent>
<ComboboxContent :aria-label="__('Search results')">
<ComboboxViewport class="max-h-[360px] min-h-[360px] divide-y divide-gray-200/80 overflow-y-auto dark:divide-gray-950">
<ComboboxEmpty v-if="query && !results.length" class="px-3 py-2 opacity-50">
<CommandPaletteItem :text="__('No results found!')" icon="entry" disabled />
Expand Down Expand Up @@ -397,18 +397,18 @@ router.on('start', () => Statamic.$commandPalette.clear());
</ComboboxItem>
</ComboboxGroup>
</ComboboxViewport>
<footer class="flex items-center gap-4 rounded-b-xl border-t border-gray-200/80 bg-gray-50 px-6 py-3 dark:border-gray-950 dark:bg-gray-800/20">
<div class="flex items-center gap-1.5">
<Icon name="up-square" class="size-4 text-gray-500" />
<Icon name="down-square" class="size-4 text-gray-500" />
<span class="text-sm text-gray-600 dark:text-gray-500">{{ __('Navigate') }}</span>
</div>
<div class="flex items-center gap-1.5">
<Icon name="return-square" class="size-4 text-gray-500" />
<span class="text-sm text-gray-600 dark:text-gray-500">{{ __('Select') }}</span>
</div>
</footer>
</ComboboxContent>
<footer @mousedown.prevent class="flex items-center gap-4 rounded-b-xl border-t border-gray-200/80 bg-gray-50 px-6 py-3 dark:border-gray-950 dark:bg-gray-800/20">
<div class="flex items-center gap-1.5">
<Icon name="up-square" class="size-4 text-gray-500" />
<Icon name="down-square" class="size-4 text-gray-500" />
<span class="text-sm text-gray-600 dark:text-gray-500">{{ __('Navigate') }}</span>
</div>
<div class="flex items-center gap-1.5">
<Icon name="return-square" class="size-4 text-gray-500" />
<span class="text-sm text-gray-600 dark:text-gray-500">{{ __('Select') }}</span>
</div>
</footer>
</ComboboxRoot>
</motion.div>
</DialogContent>
Expand Down
Loading