Repository navigation
[6.x] Fix invalid ARIA in the command palette - #15759
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command palette's listbox had the keyboard hint footer inside it and no accessible name, so axe flagged
aria-required-childrenandaria-input-field-name. This moves the footer out of the listbox (clicking it keeps focus on the search input), labels the listbox, and addsaria-modal="true"to the dialog.Two of the reported violations are left alone:
aria-controlscomes from reka-ui.ComboboxRootprovidescontentIdas a plain value, so the input never picks up the id thatComboboxContentassigns later (aria-controls is emitted as an empty string on comboboxes, popovers and date pickers #15400).Related: #15399
🤖 Generated with Claude Code