Add an execution platform for the Canonical conformance suite - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Duplicating specification example fixtures in the compiler repository may cause the canonical language contract and compiler tests to be updated independently. We directly execute the normalized IR / diagnostic contract and conformance suite published by
stack-sh/specification, and reproducibly record the supported specification for each compiler revision.Depends on stack-sh/specification#1.
Implementation Details
tests/specification-revision.serde_jsonto dev dependencies only, avoiding any increase in runtime dependencies for the compiler library.Testing Details
cargo +stable fmt --checkcargo +stable testSTACK_SPECIFICATION_DIR=../specification cargo +stable test --features conformance --test conformancecargo +stable clippy --all-targets --all-features -- -D warningsRUSTDOCFLAGS='-D warnings' cargo +stable doc --no-depscargo +stable llvm-cov --lib --all-features --workspace --fail-under-lines 95 --fail-under-functions 95 --fail-under-regions 95 --summary-onlycargo +1.85.0 testcargo +1.85.0 clippy --all-targets --all-features -- -D warningsCoverage result: regions 97.71%, functions 98.86%, lines 98.62%.
Review Points / Concerns
tests/specification-revisionneeds to be updated to that SHA once the merge commit is finalized