Skip to content

Pin the expanded diagnostic conformance suite - #4

Merged
konojunya merged 1 commit into
mainfrom
jj/pin-expanded-diagnostic-conformance
Sep 3, 2026
Merged

Pin the expanded diagnostic conformance suite#4
konojunya merged 1 commit into
mainfrom
jj/pin-expanded-diagnostic-conformance

Conversation

@konojunya

Copy link
Copy Markdown
Contributor

Background

The canonical specification now covers all 22 Stack 1.0 diagnostics emitted by compiler stages 1 through 4. The compiler must pin the final squash commit from stack-sh/specification#2 before claiming conformance with that expanded suite.

Implementation

  • Update tests/specification-revision to 8a4cf2ec97f5fba702ba3f27388fcab31f039ef5.
  • Keep compiler behavior unchanged; the existing conformance adapter already matches every new code, severity, end-exclusive range, and diagnostic ordering expectation.

Testing

  • cargo +stable fmt --check
  • cargo +stable test
  • STACK_SPECIFICATION_DIR=../specification cargo +stable test --features conformance --test conformance
  • cargo +stable clippy --all-targets --all-features -- -D warnings
  • RUSTDOCFLAGS=-D warnings cargo +stable doc --no-deps
  • cargo +stable llvm-cov --lib --all-features --workspace --fail-under-lines 95 --fail-under-functions 95 --fail-under-regions 95
  • cargo +1.85.0 test
  • cargo +1.85.0 clippy --all-targets --all-features -- -D warnings
  • Coverage: 97.71% regions, 98.86% functions, 98.62% lines

Review focus / concerns

Confirm that the pinned revision is the final squash commit from specification PR #2. This PR changes no parser, validation, IR, or diagnostic implementation.

@konojunya
konojunya merged commit a87d126 into main Sep 3, 2026
2 checks passed
@konojunya
konojunya deleted the jj/pin-expanded-diagnostic-conformance branch September 3, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant