Pin the expanded diagnostic conformance suite - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The canonical specification now covers all 22 Stack 1.0 diagnostics emitted by compiler stages 1 through 4. The compiler must pin the final squash commit from stack-sh/specification#2 before claiming conformance with that expanded suite.
Implementation
tests/specification-revisionto8a4cf2ec97f5fba702ba3f27388fcab31f039ef5.Testing
cargo +stable fmt --checkcargo +stable testSTACK_SPECIFICATION_DIR=../specification cargo +stable test --features conformance --test conformancecargo +stable clippy --all-targets --all-features -- -D warningsRUSTDOCFLAGS=-D warnings cargo +stable doc --no-depscargo +stable llvm-cov --lib --all-features --workspace --fail-under-lines 95 --fail-under-functions 95 --fail-under-regions 95cargo +1.85.0 testcargo +1.85.0 clippy --all-targets --all-features -- -D warningsReview focus / concerns
Confirm that the pinned revision is the final squash commit from specification PR #2. This PR changes no parser, validation, IR, or diagnostic implementation.