Repository navigation
fix(crosscode): keep private shared out of published manifest + add 0.7.0 changeset - #139
Merged
Merged
Conversation
@crosscode/shared is private and not published to npm, but it was listed under dependencies. tsup bundles it via noExternal, so it is not needed at runtime. Publishing with it in dependencies would make consumers resolve a non-existent package. Move it back to devDependencies so the published manifest stays installable.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The published
crosscodepackage is stale (0.6.9), and the next release would ship a broken manifest.packages/crosscodelisted the private workspace package@crosscode/sharedunderdependencies:@crosscode/sharedisprivate: trueand is not published to npm (404). tsup already bundles it vianoExternal: [/@crosscode\/shared/], so it is not needed at runtime. Publishing as-is would make everynpm i -g crosscodetry to resolve a non-existent package.Changes
@crosscode/sharedback todevDependenciesso the published manifest only contains real runtime deps (@sentry/node,chalk,cross-spawn,ora,qrcode,ws).minorchangeset covering the unpublised CLI work since0.6.9(opt-in Sentry, projectId entropy hardening, tunnel/port/keypress fixes, Windows v2 startup, tier/v2 health, cli.ts refactor, tsup bundling).Together with the existing
.changeset/tidy-pandas-scan.md(QR fix), the next version PR will bumpcrosscodeto 0.7.0 with a complete changelog.Verification
pnpm --filter crosscode buildsucceeds.dist/cli.jscontains no external@crosscode/sharedimport;encodeQrPayloadis inlined.npm pack --dry-runmanifest no longer lists@crosscode/sharedunder dependencies.Note
Publishing will be done manually (CI publish is currently failing). The open "chore: version packages" PR (#136) will be regenerated by changesets/action after this merges.