Repository navigation
fix(crosscode): sync lockfile and normalize publish metadata - #140
Merged
Merged
Conversation
- Update pnpm-lock.yaml so @crosscode/shared is recorded as a devDependency, matching package.json. Without this, the Version workflow fails with ERR_PNPM_OUTDATED_LOCKFILE and never opens a release PR. - Use "dist/cli.js" for bin and "git+https://..." for repository.url so npm publish no longer emits auto-correction warnings.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The merge of #139 changed
packages/crosscode/package.json(moved@crosscode/sharedtodevDependencies) but did not updatepnpm-lock.yaml. As a result the Version workflow failed onmain:Because of that failure, changesets/action never regenerated the "chore: version packages" PR (#136), so the
0.7.0release is stuck.Changes
@crosscode/sharedunderdevDependenciesfor thepackages/crosscodeimporter, matchingpackage.json."bin": { "crosscode": "dist/cli.js" }and"repository.url": "git+https://github.com/snhsish/crosscode.git"sonpm publishstops emitting auto-correction warnings (thebin[...] ... was invalid and removedmessage is misleading — the entry is kept, just normalized).Verification
pnpm install --frozen-lockfile --lockfile-only→ "Done" (lockfile in sync).npm publish --dry-run→ no warnings (only the expected "cannot publish over 0.6.9" until the version is bumped).npm packinternal manifest keeps"bin": { "crosscode": "./dist/cli.js" }/dist/cli.jsand drops@crosscode/sharedfromdependencies.After merge
The Version workflow re-runs, updates PR #136 to bump
crosscode0.7.0 (minor changeset + QR patch changeset), after which it can be merged and published.