[CCIP-12413] fix(loop): don't hold client conn lock while dialing#2250
Closed
makramkd wants to merge 1 commit into
Closed
[CCIP-12413] fix(loop): don't hold client conn lock while dialing#2250makramkd wants to merge 1 commit into
makramkd wants to merge 1 commit into
Conversation
- Dial outside clientConn.mu so an in-flight refresh no longer blocks concurrent callers reading a still-valid connection - Serialize refreshes via a context-aware lock so a caller with a deadline aborts instead of waiting out another slow/stuck refresh - Assign cc/deps under the lock only once dialing succeeds, avoiding deps left pointing at closed resources on a failed dial
Contributor
📊 API Diff Results
|
makramkd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket w/ detailed explanation: https://smartcontract-it.atlassian.net/browse/CCIP-12413
Requires
Supports