Skip to content

[CCIP-12413] fix(ccip): bound per-chain reader/writer creation#23105

Merged
makramkd merged 1 commit into
developfrom
mk/add-launcher-ctx
Jul 14, 2026
Merged

[CCIP-12413] fix(ccip): bound per-chain reader/writer creation#23105
makramkd merged 1 commit into
developfrom
mk/add-launcher-ctx

Conversation

@makramkd

@makramkd makramkd commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@makramkd
fix(ccip): bound per-chain reader/writer creation
7840e66 
- Wrap each chain's reader/writer create, bind, and start in a 10s
  context during oracle creation
- The launcher context has no deadline, so a down chain LOOPP would
  block the gRPC refresh loop forever, freezing the launcher and
  pinning the shared relayer connection
- A dead chain now fails fast and the launcher retries next tick
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production

cl-sonarqube-production Bot commented Jul 14, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
1 New issue
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@trunk-io

trunk-io Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@makramkd makramkd marked this pull request as ready for review July 14, 2026 09:02
@makramkd makramkd requested a review from a team as a code owner July 14, 2026 09:02
@makramkd makramkd added this pull request to the merge queue Jul 14, 2026
Merged via the queue into develop with commit 70f11e1 Jul 14, 2026
218 checks passed
@makramkd makramkd deleted the mk/add-launcher-ctx branch July 14, 2026 10:10
HashWrangler added a commit that referenced this pull request Jul 15, 2026
@HashWrangler
Merge pull request #23139 from smartcontractkit/felix/hot-fix-1
f8b891b 
[CCIP-12413] fix(ccip): bound per-chain reader/writer creation (#23105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KodeyThomas KodeyThomas KodeyThomas approved these changes
@kirtan-amin kirtan-amin kirtan-amin approved these changes
@carte7000 carte7000 Awaiting requested review from carte7000 carte7000 is a code owner automatically assigned from smartcontractkit/ccip-offchain
@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain
@AmrMohamedRezk AmrMohamedRezk Awaiting requested review from AmrMohamedRezk AmrMohamedRezk is a code owner automatically assigned from smartcontractkit/ccip-offchain
@agusaldasoro agusaldasoro Awaiting requested review from agusaldasoro agusaldasoro is a code owner automatically assigned from smartcontractkit/ccip-offchain
@ogtownsend ogtownsend Awaiting requested review from ogtownsend ogtownsend is a code owner automatically assigned from smartcontractkit/ccip-offchain
@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@makramkd @KodeyThomas @kirtan-amin