Skip to content

fix(errors): actionable table read timeouts, 409 for duplicate custom tools, Instagram revocation, selector failure logs - #9880

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/prod-log-followups-sim34
Nov 11, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/prod-log-followups-sim34

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Table reads that hit the read statement timeout now return a 400 with code TABLE_QUERY_TIMEOUT and a readable message, instead of an opaque 500 "Failed to query rows". Sorting or range-filtering on a stored column reads every row's JSONB, so a large table can exceed the 15s guard on every attempt; the message points at the indexed createdAt/updatedAt sort, equality filters, or an Expiration column. Only the structured row query (the one that takes sort and filter) converts it; list, search, and write paths keep the raw error.
  • POST /api/tools/custom answers a duplicate title (and a concurrent unique violation) with 409 instead of 500. The duplicate check now throws a typed CustomToolTitleConflictError.
  • Instagram refresh code 190 (Graph API OAuthException: token logged out, revoked, or expired) is now recognized as a credential revocation, so the credential is flagged for reconnect and logged at WARN like other providers.
  • Selector provider failures now log the endpoint (host + path, no query string), the reason, and the upstream status before being reduced to a 4xx/502. Previously nothing recorded why a selector returned 502.

Type of Change

  • Bug fix

Testing

  • New regression tests, each shown red with its guard reverted: duplicate-title 409 and the concurrent 23505 path (route.test.ts), statement-timeout mapping (rows.test.ts), Instagram 190 scoped to Instagram only (terminal-errors.test.ts)
  • Ran route.test.ts, rows.test.ts, terminal-errors.test.ts, http.test.ts, use-cases.test.ts, credential-service.test.ts: 210 passed
  • biome check on changed files; full type-check and audits left to CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

… tools, Instagram revocation, selector failure logs
@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 11, 2026 6:45pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The PR makes several errors easier to understand:

  • Slow table queries now explain how callers can narrow them.
  • Custom-tool title conflicts now return a clear 409 response.
  • Instagram refresh code 190 now marks a credential for reconnection.
  • Selector failures now leave sanitized details in server logs.

The latest change keeps timeout conversion limited to structured queries. No new actionable issues were found.

Reviews (3) · Last reviewed commit: "fix(table): limit timeout guidance to th..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 11 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/table/application/rows.ts Resolved
Comment thread apps/sim/lib/table/application/rows.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 11 files

Confidence score: 4/5

  • The timeout message in rows.ts suggests callers control sorting and filtering, but these endpoints expose only limit, cursor, includeRunState, or free-text search. Update the advice so callers can act on it.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/lib/table/application/rows.ts">

<violation number="1" location="apps/sim/lib/table/application/rows.ts:518">
P2: This timeout message assumes the caller controls sort and filter, but `listTableRows` takes only limit, cursor, and includeRunState, and `searchTableRows` takes a free-text `q`. For those endpoints the advice cannot be followed. Consider returning endpoint-specific guidance, or a shorter message that does not suggest sort or filter changes.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/table/application/rows.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — 44b78052 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant