Repository navigation
fix(errors): actionable table read timeouts, 409 for duplicate custom tools, Instagram revocation, selector failure logs - #9880
Conversation
… tools, Instagram revocation, selector failure logs
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge. SummaryThe PR makes several errors easier to understand:
The latest change keeps timeout conversion limited to structured queries. No new actionable issues were found. Reviews (3) · Last reviewed commit: "fix(table): limit timeout guidance to th..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…oute test context
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 11 files
Confidence score: 4/5
- The timeout message in
rows.tssuggests callers control sorting and filtering, but these endpoints expose only limit, cursor, includeRunState, or free-text search. Update the advice so callers can act on it.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/lib/table/application/rows.ts">
<violation number="1" location="apps/sim/lib/table/application/rows.ts:518">
P2: This timeout message assumes the caller controls sort and filter, but `listTableRows` takes only limit, cursor, and includeRunState, and `searchTableRows` takes a free-text `q`. For those endpoints the advice cannot be followed. Consider returning endpoint-specific guidance, or a shorter message that does not suggest sort or filter changes.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
TABLE_QUERY_TIMEOUTand a readable message, instead of an opaque 500 "Failed to query rows". Sorting or range-filtering on a stored column reads every row's JSONB, so a large table can exceed the 15s guard on every attempt; the message points at the indexedcreatedAt/updatedAtsort, equality filters, or an Expiration column. Only the structured row query (the one that takes sort and filter) converts it; list, search, and write paths keep the raw error.POST /api/tools/customanswers a duplicate title (and a concurrent unique violation) with 409 instead of 500. The duplicate check now throws a typedCustomToolTitleConflictError.OAuthException: token logged out, revoked, or expired) is now recognized as a credential revocation, so the credential is flagged for reconnect and logged at WARN like other providers.Type of Change
Testing
route.test.ts), statement-timeout mapping (rows.test.ts), Instagram 190 scoped to Instagram only (terminal-errors.test.ts)route.test.ts,rows.test.ts,terminal-errors.test.ts,http.test.ts,use-cases.test.ts,credential-service.test.ts: 210 passedbiome checkon changed files; full type-check and audits left to CIChecklist
test-auditauthoring gate)