Repository navigation
fix(selectors): redact email path segments from provider failure logs; correct table timeout guidance - #9908
Merged
Merged
Conversation
…; correct table timeout guidance
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryRedacts email-bearing path segments from selector provider failure logs and clarifies table timeout guidance.
Reviews (2) · Last reviewed commit: "fix(table): keep timeout guidance to sor..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 4/5
- The count guidance in
rows.tssuggests sorting bycreatedAtand keeping fewer rows, but the count endpoint supports neither, so callers may chase fixes that cannot help. Give count callers separate, accurate guidance.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/lib/table/application/rows.ts">
<violation number="1" location="apps/sim/lib/table/application/rows.ts:519">
P2: The new count wording still recommends `Sort by createdAt` and `keep fewer rows`, but the public count endpoint cannot sort and its fixed page limit does not reduce the full-view `COUNT(*)`. Give count callers separate guidance, such as narrowing to a selective equality predicate, instead of presenting row-query remedies as fixes.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@or%40). A Google Calendar id is usually its owner's address, so a failed calendar lookup was writing that address into WARN logs. Query strings and OData(...)path arguments were already stripped.TABLE_QUERY_TIMEOUTTSDoc. It claimed a retry "only times out again", but a sort or range filter on a stored column is cache-bound: the same query can finish in well under a second warm and still exceed the 15s guard cold. The doc now says why it's a 400.Type of Change
Testing
http.test.tscase: a failed provider call logs the endpoint without the query string, the search text, or an email path segment. Shown red with the email redaction removed.biome check,check:comment-hygiene,check:utilsandcheck:explicit-any. The pre-pushlint:checkandtype-checkpass.Checklist
test-auditauthoring gate)