Skip to content

Build the Platform Core, Chat, and member integrations UI - #9687

Open
emir-karabeg wants to merge 428 commits into
stagingfrom
improvement/platform-core-chat
Open

emir-karabeg wants to merge 428 commits into
stagingfrom
improvement/platform-core-chat

Conversation

@emir-karabeg

@emir-karabeg emir-karabeg commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Home, Chat, Settings and organization integrations use the shared navigation shell and real routes in the isolated Platform Next.js app. The browser and Sim Desktop share the renderer. A default-off server fixture supplies populated, empty and stress states without a database.

The shared App Router layout owns the sidebar. Selecting a chat, visiting Settings, or reopening the compact drawer preserves the reader’s position. Command K uses the shared menu rows and headings: Home, Settings and Integrations keep their icons, and workspace and chat results are text-only. Search, results and shortcut hints align to one inset, and moving from pointer to keyboard leaves only the active result highlighted.

Home and Chat share a reading column and a Recents component. Home opens recent websites in another tab; dismissal carries into Chat. The activity chart switches between Tasks run and Searches without losing its date range. Widgets and notifications share a height ceiling and scroll independently. Calendar’s Now control returns to the current day and time. Events open an external tab only when a provider supplies a URL; attendees have their own popover.

Navigation, tabs, recents and attachment previews share ControlRow. Invite recipients use compact address tags with an always-visible remove button inside each tag. Form dialogs focus the first available field and restore focus on close. Invite accepts typed and pasted addresses, supports keyboard removal and leaves sending to Phase 3. Chat keeps prose and tool activity aligned, and shares its time formatting and copy feedback with the rest of the Platform.

The member Integrations inventory uses workspace catalog descriptions for each provider. Its detail shows the provider name and description, then one connected credential with its actions menu. The inline connection prompt shares Home’s Email and Calendar styling and links to the Sim Search setup guide. Eligible tool approvals remain individual. Known OAuth permissions are grouped by purpose and always visible. Managed Search providers show their actual read-only operations, including Fireflies meeting search, transcripts, and summaries. The server fixture flag gates all sample connections. Member inventory and operation mapping.

See the component ownership map, Platform contract and Core/Chat source-state inventory. To run locally: SIM_PLATFORM_FIXTURES=1 bun run --cwd apps/sim dev:platform; visit /home?state=full, /chat/weekly-review?state=full /settings?state=full, or /integrations?state=full.

Verification exercises the production Next build, Chromium with fixture-on and fixture-off servers, and the native Electron renderer. Browser journeys measure scroll bounds, hit targets and spacing, exercise keyboard selection and focus return, and distinguish resting/hover/pressed feedback in both themes. The design audit checks ownership, token and variant use, timers, modal chrome and the fixture boundary. It recognizes JSX returned by local render helpers and active route fallbacks. The tracked Platform skill and contract route new work, cleanup and Settings reviews to the correct component library, and distinguish shared preferences from decisions owned by one feature.

Stacked on #9667, which targets staging.

Chat now steers instead of queueing. A message sent during a turn is applied to that turn at its next step, through the worker's durable v2 endpoint (simstudioai/mothership#929, which must deploy first; against an older worker a message waits for the turn's end and goes out as the next turn). If the turn ends without applying it, it goes out once as the next turn under the same id, and the worker refuses it if a run already applied it. The client queue is removed from every chat surface. Undelivered messages show a status line with Retry and Dismiss. Outgoing messages survive a reload through a per-tab journal, and anything past 10 minutes never sends itself. apps/sim/scripts/test-chat-steering-e2e.ts proves this across a real browser, app, worker and database (bun run test:chat-steering:e2e, not wired into CI).

@emir-karabeg
emir-karabeg requested a review from a team as a code owner November 4, 2026 23:24
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 6, 2026 8:34pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 3/5

[Medium impact] The changes reach the standalone Platform’s Home, Chat, and Settings flows on web and Desktop.

Fix the lost Stop control and covered desktop panel tabs before merging.

Findings

  1. P1 Follow-up removes Stop ▶
  2. P1 Toolbar covers panel tabs ▶
  3. P2 Unsent messages disappear ▶
  4. P2 Saved profile edits vanish ▶
  5. P2 Navigation resets shell changes ▶

Summary

Adds standalone Home, Chat and Settings routes for browsers and Sim Desktop, with shared controls, gated fixtures and browser/Electron checks.

  • The Platform opens on Home with shared navigation and a dashboard people can customize.
  • Chat keeps drafts, attachments, and panel interactions local to the Platform session.
  • Settings adds profile, appearance, notification, and member screens to the Platform.
  • Shared controls support the new product routes, and the component workbench has its own route.
  • Build and design checks now cover the Platform product routes and Desktop renderer.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Layout["Shared ProductSession"] --> Preferences["Interface preferences"]
  Layout --> Changes["Chat edits"]
  Layout --> Page["Home, Chat or Settings page"]
  Page --> Frame["ProductFrame"]
  Frame --> Shell["PlatformShell"]
  Shell --> Local["Inbox, notices and sort state"]
  Shell --> Feature["Feature screen"]
  Feature --> Draft["Local draft or profile edits"]
Loading

Reviews (1) · Last reviewed commit: "feat(platform): build Core and Chat for ..." · Reviewed by Greptile

Comment on lines +102 to +108
onStop={
last?.response?.state === 'running' ? () => transition(last, 'stopped') : undefined
}
onSubmit={(draft) => {
const next = userTurn(draft)
if (id && !removed) {
changes.setTurnsFor(id, [...turns, next])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Follow-up removes Stop

In /chat/customer-onboarding?state=full, pressing Enter on a follow-up appends a user turn while the response is running. onStop then disappears because it checks only the last turn, which now has no response. The earlier response stays “Working” with no way to stop it. Track the running turn separately, or block submission while it is running.

Comment on lines +17 to +24
padding-inline: var(--spacing-12);
min-inline-size: 0;
height: var(--height-nav);
border-block-end: var(--spacing-stroke-default) solid var(--ui-divider);
}
:global([data-sim-desktop-title-bar]) .header {
height: var(--spacing-48);
-webkit-app-region: drag;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Toolbar covers panel tabs

With the desktop sidebar collapsed, expanding the chat panel puts its tabs under the desktop toolbar and native window buttons. The shell places the content at the top-left, but the panel header keeps only 12px of left padding. Unlike the conversation header, it does not use --ui-navigation-inset. Reserve that space when the panel takes over so its first tab and close control remain clickable.

Comment on lines +18 to +19
<ChatPanels workspaces={shell?.workspaces ?? []} data={panel} key={id?.[0] ?? 'new'}>
<ChatScreen data={data?.chat ?? null} chatId={id?.[0]} />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unsent messages disappear

Switching chats discards unsent text and selected files. MessageComposer keeps both only in local state, while this route keys the whole panel tree by chat ID. Returning to the original chat creates a fresh composer. Keep drafts in the session, keyed by chat ID, so ordinary navigation does not erase unfinished messages.

Comment on lines +20 to +21
const [displayName, setDisplayName] = useState(name ?? '')
const [picture, setPicture] = useState<string>()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Saved profile edits vanish

Saving a display name or choosing a profile picture lasts only until the user leaves Preferences. ProfileSettings owns these values locally and is removed on other Settings sections. Returning restores the fixture name and drops the picture. Keep these local edits in the session provider; no database write is needed.

Comment on lines +30 to +33
<ProductSurface preference={appearance}>
<PlatformShell data={shell} desktopTitle={desktopTitle} navigation={navigation}>
{children}
</PlatformShell>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Navigation resets shell changes

Each page creates its own PlatformShell, so moving between Home, Chat and Settings resets inbox read marks, dismissed notices and chat sorting. For example, reading an unread item, opening a chat and returning makes that item unread again. Move this session state above the page boundary, alongside the existing chat edits and interface preferences.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 issues found and verified against the latest diff

Confidence score: 3/5

  • In chat-screen.tsx, submitted attachments can reappear in the new chat when changing the chat ID remounts the composer. Clear the attachment draft when the send succeeds.
  • In workspace-list.tsx, keyboard users get no visible focus indicator on workspace buttons. Add a :focus-visible treatment.
  • In product-surface.tsx, users with a dark system theme can see a light flash before hydration. Resolve the system theme before first paint.
  • In notification-tray.module.css, notification controls can sit under the home indicator on notched mobile browsers. Account for the bottom safe-area inset.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/platform/design-system/components/workspace-list.tsx">

<violation number="1" location="apps/sim/platform/design-system/components/workspace-list.tsx:43">
P2: This new keyboard-focusable workspace button has no visible focus indicator because the global stylesheet removes outlines and `.workspaceHit` adds none. Add a shared or workspace-specific `:focus-visible` treatment so keyboard users can identify the active row.</violation>
</file>

<file name="apps/sim/platform/design-system/components/product-surface.tsx">

<violation number="1" location="apps/sim/platform/design-system/components/product-surface.tsx:10">
P2: System appearance always renders light on the server, causing dark-system users to see a light flash before hydration applies the media-query result. Resolve the system theme before first paint, such as with a CSS media-query path plus explicit-theme override or a small theme bootstrap.</violation>
</file>

<file name="apps/sim/platform/design-system/components/select.tsx">

<violation number="1" location="apps/sim/platform/design-system/components/select.tsx:37">
P2: An arbitrary `theme` query can reach this controlled value without matching any option, so the Theme picker renders blank even though the surrounding product falls back to `system`. Ignore values outside `options` here or pass the normalized theme from the settings screen.</violation>
</file>

<file name="apps/sim/platform/design-system/features/chat/chat-screen.tsx">

<violation number="1" location="apps/sim/platform/design-system/features/chat/chat-screen.tsx:100">
P2: The first send from `/chat` clears the composer only until `router.replace` changes `id`; this prop then remounts `MessageComposer` with the unchanged draft attachments, so submitted files reappear in the new chat’s composer. Track and consume the initial draft when submitting before navigation.</violation>
</file>

<file name="apps/sim/platform/design-system/components/notification-tray.module.css">

<violation number="1" location="apps/sim/platform/design-system/components/notification-tray.module.css:10">
P2: The fixed notification stack ignores the bottom safe-area inset, so its action and dismiss controls can sit under the home indicator on notched mobile browsers. Use `max(var(--spacing-20), env(safe-area-inset-bottom))` for the bottom offset.

(Based on your team's feedback about toast safe-area minimum.) [8c7692a3-398e-4004-b266-f2a76922d36c]</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/platform/app/layout.tsx Resolved
@emir-karabeg emir-karabeg changed the title Build the Core and Chat UI for web and Sim Desktop Build the Platform Core, Chat, and organization integrations UI Nov 5, 2026
@emir-karabeg emir-karabeg changed the title Build the Platform Core, Chat, and organization integrations UI Build the Platform Core, Chat, and member integrations UI Nov 5, 2026
@waleedlatif1
waleedlatif1 force-pushed the improvement/platform-core-chat branch from 6133099 to 8d35586 Compare November 5, 2026 06:55
assertDeployableMode had only a unit test of the function, nothing showing Next
stops the server when register() throws. These start the real build as a process
and read its exit code and message, with a control that the same command starts.
A message that reached failed or applied kept its notBefore, and the timer took
the minimum across every message whatever its status, so it fired at 0ms and
ran a settle pass per tick until Retry or Dismiss. A pending or steered message
whose delay ended under a running turn spun the same way.

Every move to failed or applied clears the delay. The timer arms only for a
pending or steered message whose delay was still running when the last pass
began: comparing against now instead would strand a steered message whose delay
ended during another message's read.
…steered

The steer body has no search scope, so a Summarize sent during a turn ran without
its document scope. canSteer now refuses such a message, and the path that steers
a send the chat refused as busy goes through it too, since it skips the step's gate.
…ng rows

A steered message or a message shown as not delivered renders after the answer,
and the row counted as last. A running answer with no output yet rendered nothing
and lost its thinking indicator, and the last answer's choices stopped responding.
A reveal that outlived its stream also never reported settling.

The answer's last-row behavior now reads the last row that is not on its way into
a turn or shown as not delivered.
…ation's pauses

The planner cannot estimate jsonb_path_exists, so under LIMIT 1 it expected an
early match and scanned paused_executions from the top. A workspace with no
person-waiting pause read the whole table, every tenant's pauses included. With
the pauses as a lateral of their own it has to start from the workspace's
workflows and take the workflow_id index, so no new index is needed.

The test measures the real plan on real PostgreSQL: 110,020 rows read before,
5,000 after.
A second message sent during a new chat's admission went back to pending in the
dead mount: only the withdrawn send was handed off, and a provisional key is not
journaled. A message waiting on a retry delay was lost the same way.

Everything under the provisional key now goes on, in order. A stored handoff holds
one message, so handing each off in turn would overwrite the first: the first goes
through the handoff under its id, and the rest wait in the journal for the surface
that resumes it. One shown as not delivered stays that way.
The clock read the last message, which is the steered one while it trails the
running response, so the countdown froze. It now reads the live response.
A refetch mid-turn can return the saved answer after a steering row. Only the row
right after the owner was checked, so the live answer was added beside it and the
turn showed two answers until it ended. It now walks past steering rows with
findAssistantAfterOwner, as the reconcile path does.
A spy taken on setTimeout under fake timers was restored by the shared config after
useRealTimers, which put the fake back: every later real-timer test in the file hung
in sleep. Count reads of the cached chat, which every delivery pass makes, instead.
Better Auth keys it on client IP and path, so every phase's fresh sign-ins chain
into one budget whoever signs in. The zone-5xx phase's first test was refused
with a 429 at its fourth sign-in in 15 seconds, and the zone had no part in it.
waitForRollout reads the surface API, whose route bundle has its own AppConfig
cache. The layout's bundle still held the rollback for one more read, so a single
navigation right after the API agreed stayed on /o. The proxy's zone verdict was
never negative in that phase.
Throwing from register() never stopped the process: Next logs 'Failed to prepare
server' and keeps listening, answering 500 to everything, so the zone's guard
looked alive to anything supervising it. It now logs and exits 1. Reproduced on a
tiny production build of the same Next version, which stayed up before this and
exits 1 after it. The live spec already asserted the exit, which is how this
surfaced.
check:platform-design holds @sim/logger to lib/data, and the zone's proxy imports
mode.ts, so it gets its own module.
waleedlatif1 added a commit that referenced this pull request Nov 6, 2026
* Revert "improvement(org): move the People page onto the new design system (#9720)"

This reverts commit 7625929.

* Revert "fix(org): drop the removed shortcuts slot from the landing test (#9715)"

This reverts commit f17f1b6.

* Revert "improvement(org): move the organization view onto the new design system (#9708)"

The redesigned org view ships all at once with #9687. The shared modules later
staging work builds on stay: member-integrations and the accounts key factory.
The legacy integration detail opens the saved-credential modal for Jama and Flow,
which #9723 added only to the new view.

* fix(org): keep staging's shared modules and revert only the redesigned views

Hooks, contracts, key factories and lib helpers stay at staging, and the legacy
view adapts to them. Jama and Flow reconnect through the saved-credential modal
and disconnect through Search. Exports only the new views used are unexported or
deleted, and the e2e script returns to the legacy view's selectors.
…9740

# Conflicts:
#	apps/sim/ee/organization-usage/components/usage-consumers.tsx
…9740

# Conflicts:
#	AGENTS.md
#	AGENTS.md~HEAD
#	CLAUDE.md
… Home widgets

Owned credentials exclude one awaiting reconnection. Read in parallel, a concurrent
read that refused a token could drop an account from the owned set after its status
read 'active', and the widget reported it as not offered instead of asking to
reconnect.

This branch was previously deployed

1 inactive deployment
Preview — 6f01b80a Deployed Nov 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants