Skip to content

revert(org): hold the org view and People redesigns for #9687 - #9740

Merged
waleedlatif1 merged 4 commits into
stagingfrom
revert/org-view-ui-from-staging
Nov 6, 2026
Merged

waleedlatif1 merged 4 commits into
stagingfrom
revert/org-view-ui-from-staging

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Takes the redesigned organization view (#9708), the People page redesign (#9720) and its landing test fix (#9715) off staging, so main can keep releasing while the new UI ships all at once with #9687, which already carries all three.

After this, staging's /o UI matches main except 6 integration files that carry functional work later PRs added to the legacy view:

Only views are reverted. Hooks, contracts, key factories and lib helpers stay at staging's versions, and the legacy view adapts to them. Exports that only the redesigned views used are unexported where their own file still uses them, or deleted, so the unused-exports baseline only shrinks (2 entries).

Three API routes go: Home calendar, Home email and search-history sources. Only the new view called them, and none is on main. No reverted commit has a migration or schema change.

Merging this into #9687

#9687 already contains these commits, so a plain staging merge there would delete the org view (257 conflicting files in a dry run). After this merges, #9687 takes staging in three steps:

  1. Merge staging up to this commit's parent.
  2. git merge -s ours <this squash commit>.
  3. Merge the rest of staging.

A simulation changed 0 org-view files on #9687 and brought in every other staging commit.

Type of Change

Testing

  • type-check passes.
  • check:test-types, explicit-any, skills, biome, test-patterns, boundaries, react-query, source-conventions, file-names, utils, client-boundary, comment-hygiene, api-validation:strict, guidance-refs and unused-exports all pass. The unused-exports baseline shrank by one entry.
  • Focused vitest: 351 files, 2,830 tests pass, covering app/o, all of hooks/, credential groups, org lib, search, People, _shell and workspace Home.
  • test-assistant-actions-e2e.ts is back at main's legacy-view selectors.
  • Needs a staging check of /o Home, Integrations (including Jama or Flow connect) and People after merge.

…ign system (#9708)"

The redesigned org view ships all at once with #9687. The shared modules later
staging work builds on stay: member-integrations and the accounts key factory.
The legacy integration detail opens the saved-credential modal for Jama and Flow,
which #9723 added only to the new view.
@waleedlatif1
waleedlatif1 requested a review from a team as a code owner November 6, 2026 18:38
@vercel

vercel Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 6, 2026 7:02pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The PR changes organization pages and a bounded set of workspace search behavior.

Remove the unused hook imports to satisfy the repository requirement before merging.

Summary

Restores the legacy organization and People views while keeping later account support.

  • Organization Home and Search return to the legacy app pages.
  • The organization People page returns to its legacy chart and directory.
  • The legacy Integrations page keeps account and saved-credential actions.
  • Organization Links returns to the app's resource-table view.
  • The redesign-only Home and search-history endpoints are removed.
  • Workspace knowledge search returns to its prior result and filter flow.

Reviews (2) · Last reviewed commit: "fix(org): keep staging's shared modules ..." · Reviewed by Greptile

Comment thread apps/sim/hooks/queries/people-sync.ts Resolved
…d views

Hooks, contracts, key factories and lib helpers stay at staging, and the legacy
view adapts to them. Jama and Flow reconnect through the saved-credential modal
and disconnect through Search. Exports only the new views used are unexported or
deleted, and the e2e script returns to the legacy view's selectors.
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Comments Outside Diff

These findings could not be posted inline.

  • P2 Removed hooks leave unused imports apps/sim/hooks/queries/search-history.ts:9 ▶

    search-history.ts restores removeSearchHistorySourceContract and SearchHistoryResponse, but neither is used. oauth-provider.ts also restores unused imports of useEffect, OAUTH_SEARCH_READ_SCOPE, and oauthScopeSatisfies.

    CLAUDE.md requires deleting unused imports. Remove these imports along with the hooks that needed them. This repository requirement must be satisfied before merging.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@waleedlatif1
waleedlatif1 merged commit fb9163d into staging Nov 6, 2026
96 checks passed
@waleedlatif1
waleedlatif1 deleted the revert/org-view-ui-from-staging branch November 6, 2026 19:11
waleedlatif1 added a commit that referenced this pull request Nov 6, 2026
waleedlatif1 added a commit that referenced this pull request Nov 6, 2026
#9746)

#9740 deleted the search history sources route but kept the code that
only it reached: the remove-source use case, operation, repository event
and contract, plus unused imports in the oauth-provider and search-history
hooks. Restore those files to their main versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant