Skip to content

fix(release): push chromium's index without annotations, which buildx refuses on a Docker manifest list - #798

Merged
earakely-scale merged 1 commit into
mainfrom
edgararakelyan/fd-6305-chromiums-release-publish-fails-on
Nov 19, 2026
Merged

earakely-scale merged 1 commit into
mainfrom
edgararakelyan/fd-6305-chromiums-release-publish-fails-on

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

What

The release's computer-publish pushes each composed computer app's index (today, chromium's) without the two index annotations (org.opencontainers.image.source, org.opencontainers.image.revision).

Why

v0.9.1573 published no chromium:

ERROR: annotations are not supported for Docker manifest lists; use "oci-mediatypes=true" when building the source images

A compose pushes each arch's image with docker push, which gives the images Docker media types. The buildx on GitHub's newer runner image (20261116.202.1) refuses index annotations over a Docker manifest list. The older image (20261111.196.1) let them through, which is why v0.9.1572 and v0.9.1574 published and v0.9.1573 didn't:

Release computer-publish runner image Result
v0.9.1572 20261111.196.1 published
v0.9.1573 20261116.202.1 failed
v0.9.1574 20261111.196.1 published

Once GitHub has moved every runner to the newer image, every release would fail to publish chromium. Its record would then lack chromium, and the sdk would refuse chromium's promotion.

agentenv-chromium is already public and linked to this repo, and the annotations were metadata only. The infra images' own publish keeps its annotations: those images are built with buildx, as OCI.

Not chosen (Edgar, Nov 18): adding the source label to each composed image as well, or having the composer push OCI media types, which would change every compose.

Tests

test_publish_computers_joins_each_apps_platform_manifests_into_one_index_and_records_it expects the command without the annotations. tst/unit/test_infra_build_script.py: 80 passed.

FD-6305

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Removes source and revision annotations from composed computer indexes so Chromium publishing avoids buildx's Docker manifest-list restriction.

  • Computer image indexes publish without annotations.

The PR description records that Edgar deferred adding source labels or changing the composer to push OCI media types because those alternatives would affect every compose.

Reviews (1) · Last reviewed commit: "fix(release): push chromium's index with..." · Reviewed by Greptile

… refuses on a Docker manifest list

A compose pushes each arch's image with docker push, so the images have Docker media types, and the buildx on
GitHub's newer runner image (20261116.202.1) refuses index annotations over a Docker manifest list. v0.9.1573's
computer-publish failed that way and the release recorded no chromium. agentenv-chromium is already public and
linked to the repo, and the annotations were metadata only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 19, 2026 00:43
@earakely-scale
earakely-scale merged commit cc10cd8 into main Nov 19, 2026
35 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/fd-6305-chromiums-release-publish-fails-on branch November 19, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant