Skip to content

fix(release): push infra images' index without annotations, which buildx refuses on a Docker manifest list - #805

Merged
earakely-scale merged 1 commit into
mainfrom
edgararakelyan/infra-index-no-annotations
Nov 19, 2026
Merged

earakely-scale merged 1 commit into
mainfrom
edgararakelyan/infra-index-no-annotations

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Since GitHub's 11-16 runner images, the release can't publish a rebuilt infra image. infra-publish combines each image's amd64 and arm64 builds into one index with docker buildx imagetools create --annotation …, and buildx now refuses:

ERROR: annotations are not supported for Docker manifest lists; use "oci-mediatypes=true" when building the source images

v0.9.1580 is the first release since v0.9.1566 to rebuild an infra image (the gateway), and its Publish to PyPI run failed at that step. So the release never reached PyPI, and no pin bump followed.

Job v0.9.1566 (published) v0.9.1580 (failed)
infra-publish runner image ubuntu-26.04 20261111.196.1 ubuntu-26.04 20261116.202.1
arm64 infra-build runner image ubuntu-24.04-arm 20261111.182.1 ubuntu-24.04-arm 20261116.188.1

#798 dropped the annotations from chromium's compose index for the same refusal. This does the same for infra images. Until it merges, every release that rebuilds an infra image fails this way.

Nothing is lost. Each platform build already carries org.opencontainers.image.source and org.opencontainers.image.revision as --labels (infra_build.py, the build command). The index annotations repeated them, and the labels are what link a package to its repository on GHCR.

Changes

  • .github/scripts/infra_build.py: publish runs imagetools create -t <ref> <ref>-amd64 <ref>-arm64 with no --annotation, with a one-line comment why.
  • tst/unit/test_infra_build_script.py: the publish test expects that command.

How it was tested

  • pytest tst/unit/test_infra_build_script.py: 80 passed.
  • ruff check on both files is clean.
  • On merge with bump-version, the next release rebuilds the gateway image left unpublished by v0.9.1580's failed run. That run is the check that the index now publishes.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

This change appears safe to merge.

Summary

Removes index annotations from infra image publishing so buildx can join Docker platform images without rejecting the command.

  • Infra image releases combine platform builds without index annotations.

Reviews (1) · Last reviewed commit: "fix(release): push infra images' index w..." · Reviewed by Greptile

…ldx refuses on a Docker manifest list

Since the 11-16 runner images, imagetools create refuses --annotation on an index of Docker-media-type builds, so a release that rebuilds an infra image fails at infra-publish (v0.9.1580). Each platform build already carries the source and revision as --labels. Same fix #798 made for chromium's compose.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 19, 2026 05:39
@earakely-scale
earakely-scale merged commit 45e5ca9 into main Nov 19, 2026
61 of 63 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/infra-index-no-annotations branch November 19, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant