Repository navigation
fix(release): push infra images' index without annotations, which buildx refuses on a Docker manifest list - #805
Merged
Conversation
…ldx refuses on a Docker manifest list Since the 11-16 runner images, imagetools create refuses --annotation on an index of Docker-media-type builds, so a release that rebuilds an infra image fails at infra-publish (v0.9.1580). Each platform build already carries the source and revision as --labels. Same fix #798 made for chromium's compose. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Since GitHub's 11-16 runner images, the release can't publish a rebuilt infra image.
infra-publishcombines each image's amd64 and arm64 builds into one index withdocker buildx imagetools create --annotation …, and buildx now refuses:v0.9.1580 is the first release since v0.9.1566 to rebuild an infra image (the gateway), and its
Publish to PyPIrun failed at that step. So the release never reached PyPI, and no pin bump followed.infra-publishrunner imageinfra-buildrunner image#798 dropped the annotations from chromium's compose index for the same refusal. This does the same for infra images. Until it merges, every release that rebuilds an infra image fails this way.
Nothing is lost. Each platform build already carries
org.opencontainers.image.sourceandorg.opencontainers.image.revisionas--labels (infra_build.py, the build command). The index annotations repeated them, and the labels are what link a package to its repository on GHCR.Changes
.github/scripts/infra_build.py:publishrunsimagetools create -t <ref> <ref>-amd64 <ref>-arm64with no--annotation, with a one-line comment why.tst/unit/test_infra_build_script.py: the publish test expects that command.How it was tested
pytest tst/unit/test_infra_build_script.py: 80 passed.ruff checkon both files is clean.bump-version, the next release rebuilds the gateway image left unpublished by v0.9.1580's failed run. That run is the check that the index now publishes.🤖 Generated with Claude Code


Confidence Score: 5/5
This change appears safe to merge.Summary
Removes index annotations from infra image publishing so buildx can join Docker platform images without rejecting the command.
Reviews (1) · Last reviewed commit: "fix(release): push infra images' index w..." · Reviewed by Greptile