Skip to content

test(computer): the framework-only routes test sends from a pinned image, and docker's errors say why - #732

Merged
earakely-scale merged 2 commits into
mainfrom
edgararakelyan/computer-env-test-pinned-python
Nov 17, 2026
Merged

earakely-scale merged 2 commits into
mainfrom
edgararakelyan/computer-env-test-pinned-python

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Why

main's CI failed on the v0.9.1551 bump commit, so that release didn't publish either. This time the failure was integration-local-slow (8/12):

FAILED tst/integration/computer/computer_env_test.py::test_only_agent_env_reaches_a_deployed_computers_framework_only_routes_while_its_mcp_and_card_stay_open
  subprocess.CalledProcessError: Command '['docker', 'run', '--rm', '--network', 'host', 'public.ecr.aws/docker/library/python:3.12-slim', ...]' returned non-zero exit status 125.

The same test failed the same way, exit status 125, in 4 of the last 15 failed local-backends runs: 43954413405, 43970572534, 43982081157 and 44018886899. Exit 125 means docker run itself failed, before the container ran. The test sends its request from a container of an unpinned public.ecr.aws image that is pulled at that moment, so most likely the pull failed. The run doesn't say: the helper captures docker's stderr, and CalledProcessError doesn't print it.

What changes

  • The test's request from another container runs mirror.gcr.io/library/python:3.12-slim, pinned by digest. It's the image every test Dockerfile in tst/data uses, and other integration tests pin it the same way (vm_sandbox_build_test.py, prune_test.py).
  • The computer tests' docker() helper adds docker's stderr to the CalledProcessError as a note, so a failed docker call says why in the test report.

Tests only.

Testing

  • ruff check passes. The test runs in integration-local-slow.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

The test now sends its container request from a digest-pinned Python image. Failed Docker calls include the last 2000 characters of stderr.

  • The route test sends its request from a pinned Python image.
  • Computer test failures now include Docker’s stderr.

Reviews (2) · Last reviewed commit: "test(computer): name how much of docker'..." · Reviewed by Greptile

…age, and docker's errors say why

The test's request from another container ran an unpinned public.ecr.aws python image, and docker run exited 125
before the request on main's CI four times recently, the last keeping v0.9.1551 off PyPI. It now runs the
digest-pinned mirror.gcr.io image the test Dockerfiles use, and the computer tests' docker helper adds docker's
stderr to its error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 17, 2026 05:04
Comment thread tst/integration/computer/conftest.py Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale merged commit 6780402 into main Nov 17, 2026
35 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/computer-env-test-pinned-python branch November 17, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant