Repository navigation
fix(release): the browser base's smoke starts it with init, as its image does - #741
Merged
earakely-scale merged 1 commit intoNov 17, 2026
Merged
Conversation
…age does #708 gave start-computer the subcommands init and xvfb, and the image's CMD runs start-computer init. The release's smoke of agentenv-ubuntu-24.04-browser still ran start-computer with no argument, which printed its usage and exited, so v0.9.1552's agent-build failed and agentenv-framework stayed off PyPI. A unit test now ties each base's smoke to its image's CMD. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/browser-base-smoke-starts-init
branch
November 17, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
v0.9.1552's publish run passed
main-ciand published the gateway image and the protocol. Then itsagent-build (agentenv-ubuntu-24.04-browser)failed at the smoke check, soagent-publishwas skipped andagentenv-frameworkstayed off PyPI, which still shows 0.9.1549:#708 gave the browser base's
start-computertwo subcommands:init(the root start, which starts the session's supervisord) andxvfb(which supervisord runs). The image'sCMDbecamestart-computer init, but the release's smoke in.github/scripts/infra_build.pystill ranstart-computerwith no argument. That printed the usage and exited, so supervisord never started. Only the release runs that smoke, so no pull request's CI caught it.What changes
start-computer init &, as its image'sCMDdoes. The desktop base's smoke already runsstart-desktop init &.CMD, read from its Dockerfile. It fails onmainfor the browser base and passes here, so a later change to a base's start can't leave the release's smoke behind.Testing
tst/unit/test_infra_build_script.py: 79 passed. The new test fails without the fix.start-computer initin every deploy, which the computer integration tests run in CI.This PR carries
bump-version, so merging it cuts the release that publishes #725, #731, #732, #708 and #733.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
Fixes the browser base’s release smoke check by adding the required
initargument.Reviews (1) · Last reviewed commit: "fix(release): the browser base's smoke s..." · Reviewed by Greptile