Skip to content

fix(ci): drop build:island-manifest from postbuild:apps guard suite #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jung-thomas merged 1 commit into from
Aug 11, 2026
+8 −3
Merged

fix(ci): drop build:island-manifest from postbuild:apps guard suite #1626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"clean:island-bundles": "node scripts/clean-island-bundles.cjs",
"build:apps": "npm run vendor:mediapipe && npm run vendor:imgly && npm run vendor:animegan && npm run clean:island-bundles && npm --prefix hugo-apps run build",
"build:island-manifest": "node scripts/build-island-manifest.cjs",
"postbuild:apps": "npm run build:island-manifest && tsx scripts/check-build-collisions.ts && tsx scripts/check-icon-imports.ts && tsx scripts/check-island-ui5-imports.ts && tsx scripts/check-xs-app-mta.ts && tsx scripts/check-public-endpoints.ts && tsx scripts/check-srv-qa-cp-list.ts && tsx scripts/check-srv-qa-route-drift.ts && tsx scripts/check-srv-qa-dep-parity.ts && tsx scripts/check-slug-lookups.ts && tsx scripts/check-ui5-controller-extensions.ts && tsx scripts/check-kg-meta-formatters-mirror.ts && tsx scripts/check-csrf-clients.ts && npm run check:graphql-breaking",
"postbuild:apps": "tsx scripts/check-build-collisions.ts && tsx scripts/check-icon-imports.ts && tsx scripts/check-island-ui5-imports.ts && tsx scripts/check-xs-app-mta.ts && tsx scripts/check-public-endpoints.ts && tsx scripts/check-srv-qa-cp-list.ts && tsx scripts/check-srv-qa-route-drift.ts && tsx scripts/check-srv-qa-dep-parity.ts && tsx scripts/check-slug-lookups.ts && tsx scripts/check-ui5-controller-extensions.ts && tsx scripts/check-kg-meta-formatters-mirror.ts && tsx scripts/check-csrf-clients.ts && npm run check:graphql-breaking",
"build:explore-manifest": "tsx scripts/build-explore-manifest.ts",
"build:explore": "npm --prefix app/explore install --no-audit --no-fund && npm --prefix app/explore run build && npm run build:explore-manifest",
"build:analytics-explorer": "npm --prefix app/analytics-explorer install && npm --prefix app/analytics-explorer run build",
Expand Down
9 changes: 7 additions & 2 deletions scripts/build-island-manifest.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,13 @@
// CAP-stable entries nav-dropdown/concepts-filter are emitted un-hashed and
// resolve to their bare path either way).
//
// Runs in `postbuild:apps` (package.json), right after `vite build` and well
// before `build:hugo`, so the data file exists when Hugo builds.
// Runs in `build:all` (package.json), right after `build:apps` (`vite build`)
// and well before `build:hugo`, so the data file exists when Hugo builds. It
// is deliberately NOT part of `postbuild:apps`: that target is a read-only
// static-guard suite CI invokes directly (unit-tests.yml, deploy.yml) with no
// prior `vite build`, so the Vite manifest would be absent and this step would
// hard-fail (#1604 regression). Deploy-time correctness of the baked manifest
// is instead guarded by `scripts/deploy-mta.cjs` Step 2.5.
//
// Exit codes:
// 0 wrote the data file with >= 1 entry.
Expand Down
Loading