fix(ci): drop build:island-manifest from postbuild:apps guard suite - #1626
Merged
Merged
Conversation
#1604 prepended the build-artifact step build:island-manifest to postbuild:apps, but that target is invoked directly in CI (unit-tests.yml, deploy.yml) as a read-only static-guard suite with no prior vite build. The Vite manifest is therefore absent and build-island-manifest.cjs hard-exits 1, reddening every unit-tests run on main and PRs. build:all already runs build:island-manifest explicitly after build:apps, and scripts/deploy-mta.cjs Step 2.5 guards that shipped Hugo baked hashed island paths, so removing the artifact step from the guard suite loses no coverage. Restores the pre-#1604 guards-only behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Unit-tests CI has been red on every
mainpush and PR since #1604. The failing step is Static build guards (postbuild:apps):Root cause
#1604 (
e10ab42d) prepended the build-artifact stepbuild:island-manifesttopostbuild:apps. Butpostbuild:appsis invoked directly in CI as a read-only static-guard suite —unit-tests.yml:59anddeploy.yml:231— and neither workflow runsvite build/build:appsbefore it. So the Vite manifest never exists andbuild-island-manifest.cjshard-exits 1, before any guard runs.(This is separate from #1620, which fixed the
npm teststep's island-src path assertions. The remaining red was this guard step.)Fix
Remove
build:island-manifestfrompostbuild:apps, restoring the pre-#1604 guards-only chain. Coverage is unchanged:build:allalready runsbuild:island-manifestexplicitly, right afterbuild:apps(added inedc10ce0).scripts/deploy-mta.cjsStep 2.5 already fails the deploy if shipped Hugo baked only unhashed island paths while a Vite manifest exists.This matches the project's own rule (CLAUDE.md): a build artifact needed for a correct ship must be an explicit step in
build:all, never left to a post/pre* hook.*Verification
npm run postbuild:appsnow runs the full 12-guard suite +check:graphql-breakingto completion, exit 0 (previously died on line 1).build-island-manifest.cjsexits 1 when the manifest is absent (as in fresh CI).Also updated the now-stale header comment in
build-island-manifest.cjs.