🎨 Palette: Add pagination indicator and tab-completion hint to command suggestions - #415
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
需要修改后重新提交 🔧功能方向认可 —— 分页指示器 ( 🔴 阻塞项 1:journal 文件目录名大小写错误PR 新建的是 后果:在 Linux/CI(大小写敏感)上会产生两个并存的目录,journal 从此分裂;在 macOS/Windows(大小写不敏感)上则会出现 checkout 冲突。 修复: git rm -r --cached .Jules && rm -rf .Jules
# 把内容 append 到既有的 .jules/palette.md 末尾注意 🟡 阻塞项 2:混入了无关的 prettier 重排
本仓库的格式化工具是 🟡 阻塞项 3:可选 prop 掩盖了契约totalSuggestions?: number; // = 0
startIndex?: number; // = 0
totalSuggestions: number;
startIndex: number;让类型系统兜住,而不是靠默认值兜。 ✅ 重新提交前请确认bun run verify # 全量门禁:format:check + lint + typecheck + 边界检查 + 全部测试另外建议补一个 供参考:本轮同批 PR 的处置是 #388 / #393 / #414 已合入 main,其余因重复或已被 #412 覆盖而关闭。这个 PR 是唯一带来新增 UX 价值的,所以打回而不是关闭 —— 修好上面 3 点后请重新提交。 |
I have addressed all the blocking issues:
The specific unit test passes and the formatting was fixed using |
…atory, and fix journal case
💡 What: Added dynamic pagination indicators (e.g.,
1-5 of 12) and explicit shortcut hints (⇥ complete) to the status bar of theCommandSuggestionListcomponent.🎯 Why: To improve user situational awareness when the list of suggestions is truncated due to terminal height constraints, and to make tab-completion functionality more discoverable.
📸 Before/After:
Before:
↑↓ nav · ⏎ select · esc closeAfter:
1-5 of 12 · ↑↓ nav · ⇥ complete · ⏎ select · esc close♿ Accessibility: Improves discoverability of alternative keyboard navigation and provides clearer context about list size without relying solely on visual scrolling.
PR created automatically by Jules for task 16988221816722197227 started by @YoungSx