Skip to content

🎨 Palette: Add explicit visual indicator for truncated tasks in TodoDrawer - #402

Closed
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette/todo-drawer-ux-8004211051107660630
Closed

🎨 Palette: Add explicit visual indicator for truncated tasks in TodoDrawer#402
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette/todo-drawer-ux-8004211051107660630

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

💡 What: Added an explicit visual indicator ("... and X more tasks") at the bottom of the TodoDrawer when the number of tasks exceeds maxVisible.
🎯 Why: To improve situational awareness. When dynamic lists in terminal UIs are silently truncated to fit constraints, users may mistakenly believe they have fewer items than they actually do.
📸 Before/After: Visual change in the terminal UI. (Before: list just stops. After: explicit "... and X more tasks" line).
♿ Accessibility: Ensures users interacting with the CLI are explicitly aware of hidden content, improving overall usability and understanding of system state.


PR created automatically by Jules for task 8004211051107660630 started by @YoungSx

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@YoungSx

YoungSx commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

已由 #412 实现,关闭 🎨

这个 UX 判断是对的 —— 静默截断列表确实会让用户失去情境感知。功能已经合入 main#412,commit c5b146e0),.jules/palette.md 也已记录该 learning(2026-08-29 - Truncation Awareness)。

main 上的现状(TodoDrawer.tsx):

{todos.length > maxVisible && (
  <Box flexDirection="row">
    <Box width={6}><Text> </Text></Box>
    <Box flexGrow={1}>
      <Text color={COLORS.text.muted} dimColor>
        ... and {todos.length - maxVisible} more task
        {todos.length - maxVisible === 1 ? '' : 's'}
      </Text>
    </Box>
  </Box>
)}

对齐(width={6} 缩进与上方条目的 status+priority 列对齐)和单复数处理都已到位。本 PR 作为重复关闭。

重复提交问题

同一个 TodoDrawer 截断指示器收到了 10 个 PR#386 #387 #394 #397 #400 #402 #405 #408 #410 #412),跨度 11 天,最终只有 1 个被采纳。

.jules/palette.md 里那条 learning 就是为了防止这种重复 —— 但它记录的是"要加截断指示器"这个通用原则,而 journal 显然没被用来检查"这个具体组件是否已经做过了"。建投前请:

  1. 检索 open PR 里是否已有同一组件的改动
  2. 直接读 git log -- <目标文件> 确认功能是否已落地

同批处置

  • 🎨 Palette: Add pagination indicator and tab-completion hint to command suggestions #415CommandSuggestionList 分页指示器)是本批唯一带来新增价值的 Palette PR —— 它覆盖的是另一个组件,功能不重复。已给出整改意见待重提。
  • 如果还想继续改进 TodoDrawer,可以考虑真正的增量:maxVisible 目前硬编码默认 8,未随终端高度自适应(对比 CommandInput 已经用了 UI_CONFIG.MAX_SUGGESTIONS)。这才是尚未解决的问题。

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

已由 #412 实现,关闭 🎨

这个 UX 判断是对的 —— 静默截断列表确实会让用户失去情境感知。功能已经合入 main#412,commit c5b146e0),.jules/palette.md 也已记录该 learning(2026-08-29 - Truncation Awareness)。

main 上的现状(TodoDrawer.tsx):

{todos.length > maxVisible && (
  <Box flexDirection="row">
    <Box width={6}><Text> </Text></Box>
    <Box flexGrow={1}>
      <Text color={COLORS.text.muted} dimColor>
        ... and {todos.length - maxVisible} more task
        {todos.length - maxVisible === 1 ? '' : 's'}
      </Text>
    </Box>
  </Box>
)}

对齐(width={6} 缩进与上方条目的 status+priority 列对齐)和单复数处理都已到位。本 PR 作为重复关闭。

重复提交问题

同一个 TodoDrawer 截断指示器收到了 10 个 PR#386 #387 #394 #397 #400 #402 #405 #408 #410 #412),跨度 11 天,最终只有 1 个被采纳。

.jules/palette.md 里那条 learning 就是为了防止这种重复 —— 但它记录的是"要加截断指示器"这个通用原则,而 journal 显然没被用来检查"这个具体组件是否已经做过了"。建投前请:

  1. 检索 open PR 里是否已有同一组件的改动
  2. 直接读 git log -- <目标文件> 确认功能是否已落地

同批处置

  • 🎨 Palette: Add pagination indicator and tab-completion hint to command suggestions #415CommandSuggestionList 分页指示器)是本批唯一带来新增价值的 Palette PR —— 它覆盖的是另一个组件,功能不重复。已给出整改意见待重提。
  • 如果还想继续改进 TodoDrawer,可以考虑真正的增量:maxVisible 目前硬编码默认 8,未随终端高度自适应(对比 CommandInput 已经用了 UI_CONFIG.MAX_SUGGESTIONS)。这才是尚未解决的问题。

Understood. Acknowledging that this feature is a duplicate and has already been merged (#412). I will stop work on this task. Next time, I will make sure to check git logs and existing PRs to ensure the change hasn't already been implemented for the specific component before starting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant