fix: remove linux-arm and win32-x86 from archive verification and promotion targets @W-23480655@ - #1732
Merged
Merged
Conversation
WillieRuemmele
force-pushed
the
wr/remove-dropped-architectures
branch
from
July 31, 2026 18:58
128e8da to
9a009fb
Compare
WillieRuemmele
changed the title
iowillhoit
reviewed
Jul 31, 2026
| Messages.importMessagesDirectoryFromMetaUrl(import.meta.url); | ||
| const messages = Messages.loadMessages('@salesforce/plugin-release-management', 'channel.promote'); | ||
| const TARGETS = ['linux-x64', 'linux-arm', 'win32-x64', 'win32-x86', 'darwin-x64']; | ||
| const TARGETS = ['linux-x64', 'win32-x64', 'win32-arm64', 'darwin-x64', 'darwin-arm64']; |
Contributor
There was a problem hiding this comment.
Suggested change
| const TARGETS = ['linux-x64', 'win32-x64', 'win32-arm64', 'darwin-x64', 'darwin-arm64']; | |
| const TARGETS = ['linux-x64', 'linux-arm64', 'win32-x64', 'win32-arm64', 'darwin-x64', 'darwin-arm64']; |
Contributor
There was a problem hiding this comment.
We do still ship linux-arm64, just not linux-arm (check)
Contributor
There was a problem hiding this comment.
However, we dont actually use this channel:promote script. Doesnt hurt to update this, but we use the standard oclif promote in the CLI (pjson script)
Contributor
There was a problem hiding this comment.
Whoops, my mistake, this is used. Glad we updated it 😅
We still ship linux-arm64, just not the old 32-bit linux-arm.
iowillhoit
reviewed
Jul 31, 2026
| // 'x86.tar.xz' | ||
| // 'arm64.tar.xz' | ||
| ], | ||
| linux: ['x64.tar.gz', 'x64.tar.xz'], |
Contributor
There was a problem hiding this comment.
Same here, we should add arm64 BUT it also looks like we don't use this cli:test:install script either in the cli, only the JIT one (source)
iowillhoit
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux-armandwin32-x86from thedefaultArchiveslist incli:versions:inspect— these architectures are no longer builtlinux-armandwin32-x86from theTARGETSlist inchannel:promotewin32-arm64anddarwin-arm64toTARGETSto match the current CLI build matrixContext
The CLI dropped
linux-armandwin32-x86in salesforcecli/cli#2851. Thearchives-verifynightly job now fails because it downloads stale tarballs at an old version and reports a version mismatch.Test plan
archives-verifyCI job passes on the next nightly buildchannel:promotecan be invoked with--architecture-target win32-arm64and--architecture-target darwin-arm64@W-23480655@