-
-
Notifications
You must be signed in to change notification settings - Fork 592
User guide: refresh Inventory and Custom Units screenshots #5719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: guide/11-guide-refresh-partners
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the box on this one is pretty far off
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same fix as above (8ba4bcb), re-shot and verified the box sits on the "Going out" tab. |
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see.... we are relying on the red font which is already a highlight
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed, and no red box was added here on purpose. The red numbers are the app's own shortage highlight, which is what this paragraph is describing, so drawing our red box around it would be redundant and could be mistaken for part of the UI. Left unchanged; happy to add a callout if you'd prefer one. |
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could use better highlights probably
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reworked in 8ba4bcb: the image now has two callouts, (1) the "Quantity - Total Units" field you fill in and (2) the requested "29 packs" shown beside it, with a sentence before the image explaining what you're looking at. |
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this doesn't seem right -- the new screenshot isn't about units
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch. The seed request I had cropped had no custom units on it. Replaced (8ba4bcb) with a crop of a partner request that shows "Kids Pull-Ups (5T-6T) - 3 packs" in the Request History detail, and tightened the sentence above it to say the units appear alongside the item quantities on that page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The box on this one is pretty far off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 8ba4bcb. Root cause: the highlight boxes were positioned before the viewport was resized to the page height, so anything that moved during the reflow (mostly right-aligned controls) ended up offset. The capture helper now resizes first and draws the boxes afterwards, and every annotated screenshot in this PR was re-taken with the fix. The tab box is now on the "Coming in" tab.