ci(web): visual guards — smoke test WebGL assertion + baseline generation workflow - #14
Merged
Conversation
… workflow The Godot 4.7.1 regression shipped a build whose entire UI rendered as garbled boxes, yet the smoke test passed — it only proves the engine boots. Two follow-ups: - smoke.mjs now collects 'WebGL: INVALID_*' console errors and fails after boot if any occurred. Baseline-free, and verified against live deploys: fails on the broken 4.7.1 prod build, passes on the good 4.7.0 preview build. - visual-baselines.yml: one-click ubuntu-latest run of the visual suite with --update-snapshots against a deployed URL, uploading the PNGs as an artifact — the missing step blocking MAZE_VISUAL_BASELINES=1 (baselines must be linux-generated to match CI). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the maze.ryankelly.dev text-rendering regression (see #13), so a boots-but-illegible build can never pass CI again.
1. Smoke test now asserts a clean WebGL upload path. The 4.7.1 build passed the smoke test while rendering every glyph as a garbled box — the only machine-readable signal was console spam of
WebGL: INVALID_OPERATION: texImage2D…. The smoke test now collects those and fails after boot. Verified against both live deploys: ❌ fails on current (broken) production, ✅ passes on the 4.7.0 build at preview-maze.ryankelly.dev.2.
visual-baselines.yml— one-click dispatch that runs the existing (dormant) visual suite onubuntu-latestwith--update-snapshotsagainst any deployed URL and uploads the PNGs as an artifact. This unblocks the documented procedure in docs/VISUAL_REGRESSION.md: baselines must be Linux-generated to match CI, and the web build can't be produced locally.Remaining steps to fully enable visual regression (after #13 merges and prod is healthy):
tests/visual/maze.spec.ts-snapshots/, and setMAZE_VISUAL_BASELINES: "1"in web-export.yml in the same commit🤖 Generated with Claude Code