Repository navigation
build: find mimick_vendor for test targets (fixes #2306) - #3413
Open
Aaravanand00 wants to merge 1 commit into
Open
Aaravanand00 wants to merge 1 commit into
Aaravanand00 wants to merge 1 commit into
Conversation
ABI Compliance Check✅ Verdict: compatible
✅
|
Signed-off-by: Aaravanand <aaravanand@gmail.com>
Aaravanand00
force-pushed
the
fix-mimick-link-dependency-2306
branch
from
November 15, 2026 11:16
04c7005 to
b15fde2
Compare
Contributor
Author
|
@clalancette @fujitatomoya ptal is this looks good??? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2306
rclcpp,rclcpp_action, andrclcpp_lifecyclelink several test targets against themimicklibrary and declaremimick_vendoras a<test_depend>in theirpackage.xmlfiles.However, none of their
CMakeLists.txtfiles actually invokedfind_package(mimick_vendor REQUIRED). Without this call, CMake does not import themimicktarget with its exported vendor installation paths, and instead falls back to passing plain-lmimickto the linker.When overlaying
rclcppon top of binary installations (e.g.colcon build --allow-overriding rclcpp ...),/usr/bin/ldfails to locatelibmimick.ain the isolated vendor prefix unless the environment was re-sourced after installingros-<distro>-mimick-vendor.This PR adds
find_package(mimick_vendor REQUIRED)underBUILD_TESTINGin:rclcpp/test/CMakeLists.txtrclcpp_action/CMakeLists.txtrclcpp_lifecycle/CMakeLists.txtMatching the pattern already used in
rcl/test/CMakeLists.txt.Is this user-facing behavior change?
No API changes. Fixes linker failure (
/usr/bin/ld: cannot find -lmimick) when compiling tests on overlay workspaces.Did you use Generative AI?
Yes AI was used to assist with root cause analysis and verifying CMake dependency chains.
Additional Information
ament_lint_cmake(0 problems found).