Skip to content

Fix nil pointer dereference in popCurrentExecution for non-email alert notifiers #9707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nishantmonu51 merged 2 commits into from
Jul 20, 2026
+15 −9
Merged

Fix nil pointer dereference in popCurrentExecution for non-email alert notifiers #9707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63a0815
Fix nil pointer dereference when sending alert notifications via non-…
nishantmonu51 Jul 19, 2026
962a69c
Reset msg.UnsubscribeLink in non-email notifier branch
nishantmonu51 Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions runtime/reconcilers/alert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,16 +924,22 @@ func (r *AlertReconciler) popCurrentExecution(ctx context.Context, self *runtime
if err != nil {
return err
}
urls, ok := adminMeta.RecipientURLs[""]
if !ok {
return fmt.Errorf("failed to get recipient URLs for anon user")
}
openLink, err := addExecutionTime(urls.OpenURL, executionTime)
if err != nil {
return fmt.Errorf("failed to build recipient open url: %w", err)
// Note: adminMeta may not always be available (if outside of cloud). In that case, we leave the links blank (no clickthrough available).
msg.OpenLink = ""
msg.EditLink = ""

@pjain1 pjain1 Jul 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: may be reset msg.UnsubscribeLink as well defensively and for consistency

msg.UnsubscribeLink = ""
if adminMeta != nil && adminMeta.RecipientURLs != nil {
urls, ok := adminMeta.RecipientURLs[""]
if !ok {
return fmt.Errorf("failed to get recipient URLs for anon user")
}
openLink, err := addExecutionTime(urls.OpenURL, executionTime)
if err != nil {
return fmt.Errorf("failed to build recipient open url: %w", err)
}
msg.OpenLink = openLink
msg.EditLink = urls.EditURL
}
msg.OpenLink = openLink
msg.EditLink = urls.EditURL
start := time.Now()
defer func() {
totalLatency := time.Since(start).Milliseconds()
Expand Down
Loading