Fix nil pointer dereference in popCurrentExecution for non-email alert notifiers#9707
Merged
Merged
Conversation
…email notifiers In Rill Developer, admin.GetAlertMetadata returns ErrNotImplemented and adminMeta stays nil. The non-email notifier branch dereferenced adminMeta.RecipientURLs without a nil guard, causing alerts with e.g. Slack notifiers to panic instead of sending. Now the links are left blank when admin metadata is unavailable, matching the email branch's behavior.
nishantmonu51
changed the title
popCurrentExecution\ for non-email alert notifierspopCurrentExecution for non-email alert notifiers
Collaborator
Author
|
@codex: review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pjain1
approved these changes
Jul 20, 2026
| return fmt.Errorf("failed to build recipient open url: %w", err) | ||
| // Note: adminMeta may not always be available (if outside of cloud). In that case, we leave the links blank (no clickthrough available). | ||
| msg.OpenLink = "" | ||
| msg.EditLink = "" |
Member
There was a problem hiding this comment.
nit: may be reset msg.UnsubscribeLink as well defensively and for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
admin.GetAlertMetadatareturnsErrNotImplemented, whichexecuteAlltolerates by leavingadminMetanil. The email notifier branch guards against this, but the non-email branch dereferencedadminMeta.RecipientURLsunconditionally, so an alert with a Slack (or any non-email) notifier panicked instead of sending.OpenLink/EditLinkblank and still send the notification.Checklist: