Skip to content

Report the HTTP status when a GrandSlam response is not a plist #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
izaankml wants to merge 1 commit into from
Closed

Report the HTTP status when a GrandSlam response is not a plist #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions AltSign/Sources/ALTAppleAPI+Authentication.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,9 +499,21 @@ private extension ALTAppleAPI
self.sendGSARequest(request) { (result) in
do
{
let (data, _) = try result.get()
let (data, response) = try result.get()

guard let responseDictionary = try PropertyListSerialization.propertyList(from: data, format: nil) as? [String: Any],
let propertyList: Any
do
{
propertyList = try PropertyListSerialization.propertyList(from: data, format: nil)
}
catch
{
// GrandSlam reports its own errors inside the plist, so the HTTP status only matters when the body is not one.
guard (200 ..< 300).contains(response.statusCode) else { throw ALTAppleAPIError.unknown(statusCode: response.statusCode) }
throw error
}

guard let responseDictionary = propertyList as? [String: Any],
let dictionary = responseDictionary["Response"] as? [String: Any],
let status = dictionary["Status"] as? [String: Any]
else { throw URLError(.badServerResponse) }
Expand Down